From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 158CE3AFD09 for ; Mon, 20 Jul 2026 09:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784539634; cv=none; b=dijAvlqzxI+8Ybn1Th9sT7m6MW+G2/gHBKlTsp+pQQ81h/5RWch5cllnP7sGcsPXVkBhVRVcNOLDmRWr1rORqrzgsLTsZtgxTpPt8p5e2F/7J0DRk7pvqSgmtdKZf7+mNRiDx9AS4gw8aU4Z6VxKMgpo1i4MP1fP/tkBW0g1IJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784539634; c=relaxed/simple; bh=HQMQFnSUXuBKeeJ97RIwrfO3zajoT/O4JZOcb4WgBqA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qheyg0s8Q+PTGhWdUrn6cGo908E1x9cGU4zX1FLIIN0TE1CERHY1GvTuGvIDOkAM3pMA3BiISX1Yu8MEdyQC9/TNoJgeMuDTnG9kcmIP0iimWe/BI/tHfhwm9j6b541vB7VxhzxjPLqVWw+g5lGCF8p8QVjuIJq0xapZBKG+RRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b=Tu45MQ7H; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b="Tu45MQ7H" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-472326ca506so7592182f8f.2 for ; Mon, 20 Jul 2026 02:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall.org; s=google; t=1784539631; x=1785144431; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Y5AYMZaEUXhh4z8P8i95ra+KWHKRxofJ1kLmW4+NFQs=; b=Tu45MQ7H+5RLnEld7PO9n6qcTenVbJ9h/t36LjHDk0/QrfB7gj+64IbWMdvm3kq0lg LkwhsnResq6lsLK3ctmG6LfncGowze6zTaXT5KEc5zSyWGucA6DuMEsAvUTpTt7pG49P qsyU/4GxWc6jj17ipuTfsoepF10YbuJqP5riX94kUm7soCS0g6bZWYvOphsQNxoK+pZJ 39iQOq+2W8k3KFfNgH0zAaTux/SrUwBzfIGLMBzwEGNaiOvBcBVUBBO6eN9JZ620HVjj eap5suLEfWd9GvuIFh9KHigYv6F8JL2aveMnWiZjaVuB5DHBsJ/haTozLLsas0OyDj6U SMjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784539631; x=1785144431; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Y5AYMZaEUXhh4z8P8i95ra+KWHKRxofJ1kLmW4+NFQs=; b=Ym99VuL2vptxWDfP0a+fQmaDekHqQlcxI5OTtVEvxaD+/dN6oumBDTqSq41W9zu3om 4FlJNTYawslLnE4UnyScNnAAIF7Q6Srdld82c4bUi0Db+ksGJ1Diij2+eJ3lBrtTRhnh ue9EJ9iycVsFRNSa+aB2OmWZCUD6wHQNDFtZUC2T1/sahXPRc/8tIltiHAP+GdsOUIzC warwp10TZvTbRztC/gxVthtWLtFyZJMbt9YfhgyZkGfHz5WiITfIoPykMJsdnXcfcrZn 4CfFg8KQigI85sEXtAE1Vvwp8WkGWZMBX1KA85fOm/qHAyjaBXB1/KGntcPSBUQDYQaA K+XA== X-Forwarded-Encrypted: i=1; AHgh+Ro2OKEX+JupJWVLRO0b8EkZLifnOjQT82gtWUn0Swda5Lx+GVJ2rvNSUInhpy2zBSDZPynGmtX8zT1p/xI=@vger.kernel.org X-Gm-Message-State: AOJu0YzrIs+1prbQYX9FKeZXRhNozbBnplxtMjhBhLiUFzUWaUE8I9pK /cG5ol2gHbjrd3JSTOwoGnaBPj2+3vxnVt1hhgh2d9Fv4ARJPnhxiaP8241+Y6/Z57g= X-Gm-Gg: AfdE7cm+K74CmhYlu9UPA/rFxIJHx2MvG/krPKMPwn+pX+0+jVzT9kUIgig8iM6UXT0 +3K2j6FS8H8hb9jm7QyFygJdRkRCXRJDhU92SZdvXnSilemVmeU5OHZP3nkNyFSfQq/KovDUJd1 xMhK+yH40vXPeF2HEEds1+8DYUPiU213UI45vi5Sj4zWzYRVT0oDmZ41tyhJJkMrbqT3TjPEa0U Kbm8o80p6XnZsh47pThSMe9Qvl3+30z5nLepk4RM+7P+D4SOpKLywYdRCTKV0gs+ZOBnwccpH/x EeQbFt7mMkzZNotO0nkH4jxlsC2Y9CnLBuFlRluSb2ptGvmUonq71dGSFNKnYK1ordlxX3y1dGP MV/N+Ph1HLFIweFWZDdFK3Czajv377SYR5VAjd4uGQSh8T+/COoTe6QiVM5RSeD7K41dP6XhQiH tRFG4vFvL2GR1bYVEMHDQqNo0o12amhtL1 X-Received: by 2002:a05:6000:60f:b0:47f:6d75:7a52 with SMTP id ffacd0b85a97d-47f6d757ac4mr10330530f8f.31.1784539631284; Mon, 20 Jul 2026 02:27:11 -0700 (PDT) Received: from [192.168.0.161] (78-154-15-182.ip.btc-net.bg. [78.154.15.182]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63eddd27sm28372768f8f.28.2026.07.20.02.27.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 02:27:10 -0700 (PDT) Message-ID: <103f04dd-dc48-42e0-83db-46864ca9297b@blackwall.org> Date: Mon, 20 Jul 2026 12:27:09 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 5/5] bridge: Use ndisc_parse_options() to parse ND options in br_nd_send() Content-Language: en-US, bg To: Danielle Ratson , netdev@vger.kernel.org Cc: dsahern@kernel.org, idosch@nvidia.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, ja@ssi.bg, petrm@nvidia.com, fw@strlen.de, kuniyu@google.com, bridge@lists.linux.dev, linux-kernel@vger.kernel.org References: From: Nikolay Aleksandrov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/07/2026 16:34, Danielle Ratson wrote: > Replace the manual ND option parsing loop in br_nd_send() with > ndisc_parse_options(), which provides proper validation and avoids the > class of bugs that were fixed by commit 53fc685243bd ("bridge: Avoid > infinite loop when suppressing NS messages with invalid options") and > commit 850837965af1 ("bridge: br_nd_send: validate ND option lengths"). > > Use ndisc_opt_addr_data() to extract the source link-layer address > from the parsed options, which correctly validates the option length > for the underlying device type. > > Export ndisc_parse_options() so that it can be resolved from the bridge > when it is built as a module (CONFIG_BRIDGE=m); otherwise modpost fails > with an undefined symbol. > > Reviewed-by: Petr Machata > Signed-off-by: Danielle Ratson > --- > net/bridge/br_arp_nd_proxy.c | 32 +++++++++++++++++--------------- > net/ipv6/ndisc.c | 1 + > 2 files changed, 18 insertions(+), 15 deletions(-) > Acked-by: Nikolay Aleksandrov