mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ilya Maximets <i.maximets@ovn.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: i.maximets@ovn.org, netdev@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	dev@openvswitch.org, linux-kernel@vger.kernel.org,
	Eelco Chaudron <echaudro@redhat.com>,
	Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH net-next] net: openvswitch: allow providing upcall pid for the 'execute' command
Date: Wed, 2 Jul 2025 10:10:33 +0200	[thread overview]
Message-ID: <1040d742-35b3-443d-bcb4-5df0eeb42f93@ovn.org> (raw)
In-Reply-To: <20250701192136.6b8f9569@kernel.org>

On 7/2/25 4:21 AM, Jakub Kicinski wrote:
> On Sat, 28 Jun 2025 00:01:33 +0200 Ilya Maximets wrote:
>> @@ -616,6 +618,7 @@ static int ovs_packet_cmd_execute(struct sk_buff *skb, struct genl_info *info)
>>  	struct sw_flow_actions *sf_acts;
>>  	struct datapath *dp;
>>  	struct vport *input_vport;
>> +	u32 upcall_pid = 0;
>>  	u16 mru = 0;
>>  	u64 hash;
>>  	int len;
>> @@ -651,6 +654,10 @@ static int ovs_packet_cmd_execute(struct sk_buff *skb, struct genl_info *info)
>>  			       !!(hash & OVS_PACKET_HASH_L4_BIT));
>>  	}
>>  
>> +	if (a[OVS_PACKET_ATTR_UPCALL_PID])
>> +		upcall_pid = nla_get_u32(a[OVS_PACKET_ATTR_UPCALL_PID]);
>> +	OVS_CB(packet)->upcall_pid = upcall_pid;
> 
> sorry for a late nit:
> 
> 	OVS_CB(packet)->upcall_pid =
> 		nla_get_u32_default(a[OVS_PACKET_ATTR_UPCALL_PID], 0);
> 
> ?

No worries.  I was actually looking for ways to collapse this
block, but somehow missed these "new" accessors.  I'll send a
v2 a bit later today in case there will be no further feedback.

Best regards, Ilya Maximets.

  reply	other threads:[~2025-07-02  8:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 22:01 Ilya Maximets
2025-06-27 22:09 ` Ilya Maximets
2025-07-02  2:21 ` Jakub Kicinski
2025-07-02  8:10   ` Ilya Maximets [this message]
2025-07-02 12:14 ` Aaron Conole
2025-07-02 12:37   ` Ilya Maximets
2025-07-02 12:46     ` Aaron Conole
2025-07-02 13:53 ` [ovs-dev] " Flavio Leitner
2025-07-02 14:41   ` Ilya Maximets
2025-07-02 23:08     ` Flavio Leitner
2025-07-03  8:38       ` Ilya Maximets
2025-07-03 11:04         ` Flavio Leitner
2025-07-03 11:15           ` Ilya Maximets
2025-07-03 11:26             ` Flavio Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1040d742-35b3-443d-bcb4-5df0eeb42f93@ovn.org \
    --to=i.maximets@ovn.org \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®