Re: [PATCH] TCP Zero Copy for mmapped files

["David S. Miller" <davem@redhat.com>]

On Sun, 2002-12-29 at 17:29, Larry McVoy wrote:
> How about putting this into a different function?  It's a lot to add
> inline for a special case.

This patch also has a ton of other problems:

1) Does not handle writes that straddle multiple VMAs
2) We do not want to encourage people to use this mmap
   scheme anyways.  The mmap way consumes precious VM
   space, whereas the sendfile scheme does not.
3) Finally, I'm very dubious about the "this is faster than
   TUX claim".  Firstly because you've not provided your
   self-made HTTP server so that others can try to reproduce
   your benchmark.  And secondly because you haven't indicated
   if your self-made HTTP server is as full featured as TUX or
   not.  And thirdly you haven't indicated what happens if in
   parallel clients ask to be served more files than you could
   mmap fit into the HTTP server processes address space (ie. see
   #2)

So I think this patch stinks :)