From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753809AbdKGFth (ORCPT ); Tue, 7 Nov 2017 00:49:37 -0500 Received: from mail-sh2.amlogic.com ([58.32.228.45]:25373 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdKGFtf (ORCPT ); Tue, 7 Nov 2017 00:49:35 -0500 Subject: Re: [PATCH v3 4/4] ARM64: dts: meson: drop "sana" clock from SARADC To: Kevin Hilman , , Martin Blumenstingl References: <20171107053728.32169-1-yixun.lan@amlogic.com> <20171107053728.32169-2-yixun.lan@amlogic.com> CC: , Rob Herring , Mark Rutland , Carlo Caione , Xingyu Chen , , , From: Yixun Lan Message-ID: <1042f0e2-1a13-af57-5057-6f97ff4c4aa2@amlogic.com> Date: Tue, 7 Nov 2017 13:49:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171107053728.32169-2-yixun.lan@amlogic.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.20.76] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 11/07/17 13:37, Yixun Lan wrote: > From: Xingyu Chen > > The SAR ADC modules doesn't require The "sana" clock. > > Singed-off-by: Xingyu Chen > Signed-off-by: Yixun Lan > --- > arch/arm/boot/dts/meson8.dtsi | 5 ++--- > arch/arm/boot/dts/meson8b.dtsi | 5 ++--- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +-- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 3 +-- > 4 files changed, 6 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi > index b98d44fde6b6..f93d6cf6e094 100644 > --- a/arch/arm/boot/dts/meson8.dtsi > +++ b/arch/arm/boot/dts/meson8.dtsi > @@ -289,9 +289,8 @@ > &saradc { > compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc"; > clocks = <&clkc CLKID_XTAL>, > - <&clkc CLKID_SAR_ADC>, > - <&clkc CLKID_SANA>; > - clock-names = "clkin", "core", "sana"; > + <&clkc CLKID_SAR_ADC>; > + clock-names = "clkin", "core"; > }; > > &spifc { > diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi > index bc278da7df0d..4aa444284f0c 100644 > --- a/arch/arm/boot/dts/meson8b.dtsi > +++ b/arch/arm/boot/dts/meson8b.dtsi > @@ -185,9 +185,8 @@ > &saradc { > compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc"; > clocks = <&clkc CLKID_XTAL>, > - <&clkc CLKID_SAR_ADC>, > - <&clkc CLKID_SANA>; > - clock-names = "clkin", "core", "sana"; > + <&clkc CLKID_SAR_ADC>; > + clock-names = "clkin", "core"; > }; > > &uart_AO { > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index af834cdbba79..b77f2593cdc3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -686,10 +686,9 @@ > compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc"; > clocks = <&xtal>, > <&clkc CLKID_SAR_ADC>, > - <&clkc CLKID_SANA>, > <&clkc CLKID_SAR_ADC_CLK>, > <&clkc CLKID_SAR_ADC_SEL>; > - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel"; > + clock-names = "clkin", "core", "adc_clk", "adc_sel"; > }; > > &sd_emmc_a { > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index d8dd3298b15c..07805a3b4db0 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -628,10 +628,9 @@ > compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc"; > clocks = <&xtal>, > <&clkc CLKID_SAR_ADC>, > - <&clkc CLKID_SANA>, > <&clkc CLKID_SAR_ADC_CLK>, > <&clkc CLKID_SAR_ADC_SEL>; > - clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel"; > + clock-names = "clkin", "core", "adc_clk", "adc_sel"; > }; > > &sd_emmc_a { > sorry, please drop this particular 'patch [4/4]', I've actually send it twice, others are good.