mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Dave Jones <davej@codemonkey.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev@oss.sgi.com, alan@redhat.com, akpm@digeo.com
Subject: Re: cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size)
Date: 21 Jan 2003 02:17:28 +0000	[thread overview]
Message-ID: <1043115448.13142.6.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030117174928.GA8304@gtf.org>

On Fri, 2003-01-17 at 17:49, Jeff Garzik wrote:
> > Whilst on the subject of magic numbers in net drivers, did we ever get
> > to the bottom of 2.4's ChangeSet 1.587.9.20 
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5/2.5.48/split-dj1/net-cs89x0-media-corrections.diff
> 
> 
> IIRC it came from -ac tree without explanation, and I think akpm said it
> broke stuff.  Since it has an alive maintainer (akpm), I would rather
> let Alan and Andrew fight it out :)  Whatever they decide is fine with
> me for 2.5.

I've had no reports I remember about it breaking stuff, and several that
it fixed stuff. It also seems to match the documentation. Its been in -ac
for ages


  parent reply	other threads:[~2003-01-21  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-17 14:53 eepro100 - 802.1q - mtu size Florian Lohoff
2003-01-17 16:08 ` Paul P Komkoff Jr
2003-01-17 16:28   ` Jeff Garzik
2003-01-17 17:27     ` Dave Jones
2003-01-17 17:49       ` cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size) Jeff Garzik
2003-01-17 20:14         ` Paul P Komkoff Jr
2003-01-21  2:17         ` Alan [this message]
2003-01-21 23:39           ` Jeff Garzik
2003-01-17 17:48     ` eepro100 - 802.1q - mtu size Ducrot Bruno
2003-01-17 19:25     ` Florian Lohoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1043115448.13142.6.camel@dhcp22.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@digeo.com \
    --cc=alan@redhat.com \
    --cc=davej@codemonkey.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®