From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 29 Jan 2003 10:10:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 29 Jan 2003 10:10:02 -0500 Received: from [217.167.51.129] ([217.167.51.129]:25558 "EHLO zion.wanadoo.fr") by vger.kernel.org with ESMTP id ; Wed, 29 Jan 2003 10:10:01 -0500 Subject: Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page. From: Benjamin Herrenschmidt To: Jens Axboe Cc: linux-kernel@vger.kernel.org In-Reply-To: <20030129150000.GD31566@suse.de> References: <1043852266.1690.63.camel@zion.wanadoo.fr> <20030129150000.GD31566@suse.de> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Message-Id: <1043853614.1668.70.camel@zion.wanadoo.fr> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.0 Date: 29 Jan 2003 16:20:15 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2003-01-29 at 16:00, Jens Axboe wrote: > On Wed, Jan 29 2003, Benjamin Herrenschmidt wrote: > > Hi, I just spotted this in the patch (but the code itself have been > > there since 2.4.20-pre2). > > > > > - if (((unsigned long) bh->b_data) < PAGE_SIZE) > > > + if ((unsigned long) bh->b_data < PAGE_SIZE) > > > > Didn't you meant PAGE_OFFSET and not PAGE_SIZE here ? I fail to see why > > it would make any sense to compare a virtual address to PAGE_SIZE ;) > > For highmem buffer heads, b_data is the offset into the page. Does look > confusing, I'll give you that :-) > > The test should most likely just be removed, if anything. I would agree with you if you were actually testing that ;) Look closely, the test is in the non-b_page case, that is when b_data contains a kernel virtual address. So the test should be either removed or moved to the first part of the if () statement. In our case (virtual address, not page), though, it makes some sense to test that it's higher or equal than PAGE_OFFSET since virt_to_page() won't work on addresses not part of the lowmem linear mapping. Ben.