From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page.
Date: 29 Jan 2003 16:44:15 +0100 [thread overview]
Message-ID: <1043855055.536.81.camel@zion.wanadoo.fr> (raw)
In-Reply-To: <20030129153820.GF31566@suse.de>
On Wed, 2003-01-29 at 16:38, Jens Axboe wrote:
> No, any b_data < PAGE_OFFSET is not wrong, that's the point. For highmem
> b_page, b_data will be the offset into the page. So it could be 2048,
> for instance.
In the other if() case, yes ;)
> The test is meant to catch an invalid buffer_head, where b_page is not
> set but b_data isn't valid either. So to make it complete, you could do:
Yup, I undestood that.
> if (bh->b_data < PAGE_SIZE)
> BUG();
> if (bh->b_data < PAGE_OFFSET)
> BUG();
> }
All I wanted to spot is that < PAGE_OFFSET would catch the PAGE_SIZE bug
as well ;) But that's not a problem in real life anyway it seems.
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
next prev parent reply other threads:[~2003-01-29 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-29 14:57 Benjamin Herrenschmidt
2003-01-29 15:00 ` Jens Axboe
2003-01-29 15:20 ` Benjamin Herrenschmidt
2003-01-29 15:22 ` Jens Axboe
2003-01-29 15:26 ` Benjamin Herrenschmidt
2003-01-29 15:38 ` Jens Axboe
2003-01-29 15:44 ` Benjamin Herrenschmidt [this message]
2003-01-29 15:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1043855055.536.81.camel@zion.wanadoo.fr \
--to=benh@kernel.crashing.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®