From: Steve Lord <lord@sgi.com>
To: Andy Chou <acc@cs.stanford.edu>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, mc@cs.stanford.edu
Subject: Re: [CHECKER] 112 potential memory leaks in 2.5.48
Date: 05 Feb 2003 12:16:40 -0600 [thread overview]
Message-ID: <1044469000.18872.27.camel@jen.americas.sgi.com> (raw)
In-Reply-To: <20030205011353.GA17941@Xenon.Stanford.EDU>
[BUG] Only possible if the argument len == 0.
/u1/acc/linux/2.5.48/fs/xfs/pagebuf/page_buf.c:966:pagebuf_get_no_daddr: ERROR:LEAK:966:966:Memory leak [Allocated from: /u1/acc/linux/2.5.48/fs/xfs/pagebuf/page_buf.c:966:kmalloc]
This function is never called with len == 0
[BUG] Not sure. Code path is complicated.
/u1/acc/linux/2.5.48/fs/xfs/xfs_da_btree.c:2221:xfs_da_do_buf: ERROR:LEAK:2179:2221:Memory leak [Allocated from: /u1/acc/linux/2.5.48/fs/xfs/xfs_da_btree.c:2179:xfs_da_buf_make]
The code makes me shudder, but there is no leak in here, I chased it
around and all the callers use the right set of arguments to not leak.
[BUG]
/u1/acc/linux/2.5.48/fs/xfs/xfs_dir_leaf.c:651:xfs_dir_leaf_to_shortform: ERROR:LEAK:645:651:Memory leak [Allocated from: /u1/acc/linux/2.5.48/fs/xfs/xfs_dir_leaf.c:645:kmem_alloc]
yep, that's a bug, only happens in forced shutdown of the filesystem.
[BUG]
/u1/acc/linux/2.5.48/fs/xfs/xfs_log_recover.c:1304:xlog_recover_add_to_trans: ERROR:LEAK:1294:1304:Memory leak [Allocated from: /u1/acc/linux/2.5.48/fs/xfs/xfs_log_recover.c:1294:kmem_zalloc]
Also a bug, and we don't need to zero the memory either.
Fixes for the last two will be in the pipeline with other xfs fixes to
Linus.
Thanks
Steve
--
Steve Lord voice: +1-651-683-3511
Principal Engineer, Filesystem Software email: lord@sgi.com
next prev parent reply other threads:[~2003-02-05 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-05 1:13 Andy Chou
2003-02-05 2:37 ` Rik van Riel
2003-02-05 2:42 ` [PATCH] " Rik van Riel
2003-02-05 16:19 ` James Bottomley
2003-02-05 6:06 ` Jochen Friedrich
2003-02-05 12:19 ` [PATCH] " James Morris
2003-02-07 9:24 ` David S. Miller
2003-02-05 12:20 ` James Morris
2003-02-07 9:25 ` David S. Miller
2003-02-05 18:16 ` Steve Lord [this message]
2003-02-05 23:48 ` Greg KH
2003-02-06 0:21 ` Andy Chou
2003-02-06 0:26 ` Greg KH
2003-02-06 2:26 ` Greg KH
2003-02-05 17:48 Steven French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1044469000.18872.27.camel@jen.americas.sgi.com \
--to=lord@sgi.com \
--cc=acc@cs.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®