mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Haverkamp <markh@osdl.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.5] fix megaraid driver compile error
Date: 06 Feb 2003 12:39:22 -0800	[thread overview]
Message-ID: <1044563962.4858.59.camel@markh1.pdx.osdl.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0302061202430.3545-100000@home.transmeta.com>

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Thu, 2003-02-06 at 12:04, Linus Torvalds wrote:
> On 6 Feb 2003, Mark Haverkamp wrote:
> >
> > This moves access of the host element to device since host has been
> > removed from struct scsi_cmnd.
> 
> This is whitespace-damaged.
> 
> Please fix broken mailers. I generally don't bother to fix up whitespace
> damage from people who can't bother to have a good mailer. It's just not 
> worth it - if I try to fix it up (even if it is often trivial), it just 
> means that people will continue to send crap patches to me.
> 
> 		Linus

Sorry about the bad patch.   Is an attached text file OK?


-- 
Mark Haverkamp <markh@osdl.org>

[-- Attachment #2: megaraid.patch --]
[-- Type: text/plain, Size: 654 bytes --]

===== drivers/scsi/megaraid.c 1.32 vs edited =====
--- 1.32/drivers/scsi/megaraid.c	Fri Jan  3 10:58:49 2003
+++ edited/drivers/scsi/megaraid.c	Thu Feb  6 10:18:43 2003
@@ -4515,7 +4515,7 @@
 		if(scsicmd == NULL) return -ENOMEM;
 
 		memset(scsicmd, 0, sizeof(Scsi_Cmnd));
-		scsicmd->host = shpnt;
+		scsicmd->device->host = shpnt;
 
 		if( outlen || inlen ) {
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
@@ -4652,7 +4652,7 @@
 		if(scsicmd == NULL) return -ENOMEM;
 
 		memset(scsicmd, 0, sizeof(Scsi_Cmnd));
-		scsicmd->host = shpnt;
+		scsicmd->device->host = shpnt;
 
 		if (outlen || inlen) {
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)

  reply	other threads:[~2003-02-06 20:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-06 19:20 Mark Haverkamp
2003-02-06 19:24 ` Christoph Hellwig
2003-02-06 20:04 ` Linus Torvalds
2003-02-06 20:39   ` Mark Haverkamp [this message]
2003-02-06 21:00   ` Steven Cole
2003-02-06 21:02     ` Linus Torvalds
2003-02-06 22:12       ` Steven Cole
2003-02-06 22:26         ` Linus Torvalds
2003-02-06 23:09           ` Steven Cole
2003-02-06 21:16     ` Mark Haverkamp
2003-02-06 23:19       ` David Woodhouse
2003-02-06 23:22         ` Linus Torvalds
2003-02-07  8:45           ` John Bradford
2003-02-07 14:39           ` Alan Cox
2003-02-06 23:40   ` Philippe Gramoullé
2003-02-06 19:59 Matt_Domsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1044563962.4858.59.camel@markh1.pdx.osdl.net \
    --to=markh@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®