From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "David S. Miller" <davem@redhat.com>
Cc: christopher.leech@intel.com, netdev@oss.sgi.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: skb_padto and small fragmented transmits
Date: 07 Feb 2003 13:33:41 +0000 [thread overview]
Message-ID: <1044624820.14026.7.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20030206.144306.14966745.davem@redhat.com>
On Thu, 2003-02-06 at 22:43, David S. Miller wrote:
> From: Chris Leech <christopher.leech@intel.com>
> Date: 06 Feb 2003 11:22:08 -0800
>
> OK, now I'm really getting confused. Every other example I can find in
> the networking code, and every scatter-gather capable driver, uses
> skb->len as the full length and skb->len - skb->data_len as the length
> of the first or linear portion.
>
> Indeed, Alan you need to fix the skb_padto stuff to use
> skb->len, ignore the skb->data_len as skb->len is the
> full length.
Dave just fix it next time you touch the code and push it to Marcelo. It
doesnt affect the 2.2 backport so that will be ok
next prev parent reply other threads:[~2003-02-07 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BD9B60A108C4D511AAA10002A50708F20BA2AAE3@orsmsx118.jf.intel.com>
2003-02-06 19:22 ` Chris Leech
2003-02-06 22:43 ` David S. Miller
2003-02-07 13:33 ` Alan Cox [this message]
2003-02-08 8:53 ` David S. Miller
[not found] <BD9B60A108C4D511AAA10002A50708F20BA2AAD1@orsmsx118.jf.intel.com>
2003-02-06 19:22 ` Chris Leech
2003-02-06 18:44 ` David S. Miller
2003-02-05 21:39 Chris Leech
2003-02-06 11:58 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1044624820.14026.7.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=christopher.leech@intel.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®