From: Stephen Hemminger <shemminger@osdl.org>
To: Bjorn Helgaas <bjorn_helgaas@hp.com>
Cc: "Grover, Andrew" <andrew.grover@intel.com>,
t-kochi@bq.jp.nec.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH] 2/3 ACPI resource handling
Date: 11 Feb 2003 14:14:54 -0800 [thread overview]
Message-ID: <1045001693.17351.62.camel@dell_ss3.pdx.osdl.net> (raw)
In-Reply-To: <200302111459.35380.bjorn_helgaas@hp.com>
On Tue, 2003-02-11 at 13:59, Bjorn Helgaas wrote:
> Note that this contains a couple structure copies; don't know your
> philosophy on those.
>
> Bjorn
>
>
> diff -ur acpi-2/drivers/acpi/resources/rsxface.c acpi-3/drivers/acpi/resources/rsxface.c
> --- acpi-2/drivers/acpi/resources/rsxface.c 2003-02-09 22:13:47.000000000 -0700
> +++ acpi-3/drivers/acpi/resources/rsxface.c 2003-02-09 22:13:52.000000000 -0700
> @@ -316,3 +316,65 @@
> status = acpi_rs_set_srs_method_data (device_handle, in_buffer);
> return_ACPI_STATUS (status);
> }
> +
> +
> +#define copy_field(out, in, field) out->field = in->field
> +#define copy_address(out, in) \
> + copy_field(out, in, resource_type); \
> + copy_field(out, in, producer_consumer); \
> + copy_field(out, in, decode); \
> + copy_field(out, in, min_address_fixed); \
> + copy_field(out, in, max_address_fixed); \
> + copy_field(out, in, attribute); \
> + copy_field(out, in, granularity); \
> + copy_field(out, in, min_address_range); \
> + copy_field(out, in, max_address_range); \
> + copy_field(out, in, address_translation_offset); \
> + copy_field(out, in, address_length); \
> + copy_field(out, in, resource_source);
If ACPI just used normal (ie short) variable names, then ugly macros
like this would not be necessary.
next prev parent reply other threads:[~2003-02-11 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-11 21:59 Bjorn Helgaas
2003-02-11 22:14 ` Stephen Hemminger [this message]
2003-02-11 22:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045001693.17351.62.camel@dell_ss3.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=acpi-devel@lists.sourceforge.net \
--cc=andrew.grover@intel.com \
--cc=bjorn_helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=t-kochi@bq.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®