From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: PATCH: make the sl82c105 work again
Date: 18 Feb 2003 21:49:27 +0100 [thread overview]
Message-ID: <1045601367.570.56.camel@zion.wanadoo.fr> (raw)
In-Reply-To: <20030218185309.C9785@flint.arm.linux.org.uk>
On Tue, 2003-02-18 at 19:53, Russell King wrote:
> On Tue, Feb 18, 2003 at 06:34:29PM +0000, Alan Cox wrote:
> > + hwif->drives[0].pio_speed = XFER_PIO_0;
> > + hwif->drives[0].autotune = 1;
> > + hwif->drives[1].pio_speed = XFER_PIO_1;
> > + hwif->drives[1].autotune = 1;
>
> Is there some reason why drive 1 is PIO 1 and drive 0 is PIO 0 ?
No, just a typo from me that I forgot to send a patch for.
There is also still a problem. If DMA fails, the main IDE layer
goes back to PIO, that works, and then goes back to DMA, it
calls hwif->ide_dma_on() from IRQ with lock held etc...
The problem is that if I fix that, that means the proper setting
up of the disk for DMA etc... will not be done in ide_dma_on
anymore but only on ide_dma_check() (so once upon discovery)
and when setting xfer mode. Not on hdparm -d1. I'm still wondering
what is the best fix for that. For ide-pmac, I did the later
(only do the job in check()), but I also think we should change
ide.c to actually call hwif->ide_dma_check() when DMA is turned
ON with hdparm instead of ide_dma_on().
Ben.
next prev parent reply other threads:[~2003-02-18 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-18 18:34 Alan Cox
2003-02-18 18:53 ` Russell King
2003-02-18 20:49 ` Benjamin Herrenschmidt [this message]
2003-02-19 2:05 ` Alan Cox
2003-02-23 8:13 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045601367.570.56.camel@zion.wanadoo.fr \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®