From: "David S. Miller" <davem@redhat.com>
To: Matthew Wilcox <willy@debian.org>
Cc: chas williams <chas@locutus.cmf.nrl.navy.mil>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.5] convert atm_dev_lock from spinlock to semaphore
Date: 18 Feb 2003 20:47:36 -0800 [thread overview]
Message-ID: <1045630056.10926.4.camel@rth.ninka.net> (raw)
In-Reply-To: <20030219025347.D22992@parcelfarce.linux.theplanet.co.uk>
On Tue, 2003-02-18 at 18:53, Matthew Wilcox wrote:
> you seem to be under the impression that <linux/sem.h> has something
> to do with linux semaphores. this is not the case; they're sysv semaphores.
I agree, this bit has to be fixed.
> atm really needs fixing properly.
True, but his change by itself is OK. All of the places where
atm_dev_lock is acquired it is safe to do things like sleep.
While checking this I notice that atm_alloc_dev uses GFP_ATOMIC
thus unnecessarily.
Anyways, Matt, without a full time ATM maintainer and having basically
nobody who wants to take that on, we should take the small fixes when
they do occur and are correct as Chas's patch is.
next prev parent reply other threads:[~2003-02-19 3:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-19 2:53 Matthew Wilcox
2003-02-19 4:47 ` David S. Miller [this message]
2003-02-19 5:01 ` chas williams
2003-02-19 4:53 ` David S. Miller
2003-02-19 18:33 ` Mitchell Blank Jr
2003-02-19 21:19 ` Mr. James W. Laferriere
2003-02-19 4:52 ` chas williams
2003-02-19 14:30 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2003-02-18 21:26 chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1045630056.10926.4.camel@rth.ninka.net \
--to=davem@redhat.com \
--cc=chas@locutus.cmf.nrl.navy.mil \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®