From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: check cpu_online() in nr_running()
Date: 25 Feb 2003 18:32:43 +0000 [thread overview]
Message-ID: <1046197963.4055.15.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20030225163335.GD10396@holomorphy.com>
On Tue, 2003-02-25 at 16:33, William Lee Irwin III wrote:
> for (i = 0; i < NR_CPUS; i++)
> + if (!cpu_online(i))
> + continue;
> sum += cpu_rq(i)->nr_running;
I smell donkey poo 8)
If the change is right, which seems reasonable then I think you
need some { } 's too. Its also a hot path so it may be a lot
cleaner to keep the jump out of this by just letting
nr_running be zero for other processors ?
next prev parent reply other threads:[~2003-02-25 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-25 16:33 William Lee Irwin III
2003-02-25 18:32 ` Alan Cox [this message]
2003-02-25 17:51 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1046197963.4055.15.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®