From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 10 Mar 2003 17:23:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 10 Mar 2003 17:23:39 -0500 Received: from pc2-cwma1-4-cust86.swan.cable.ntl.com ([213.105.254.86]:41401 "EHLO irongate.swansea.linux.org.uk") by vger.kernel.org with ESMTP id ; Mon, 10 Mar 2003 17:23:38 -0500 Subject: Re: [PATCH] Update to ide-scsi error handling From: Alan Cox To: wrlk@riede.org Cc: linux-scsi@vger.kernel.org, Linux Kernel Mailing List In-Reply-To: <20030126205831.GM24610@linnie.riede.org> References: <20030126205831.GM24610@linnie.riede.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Message-Id: <1047339684.16969.9.camel@irongate.swansea.linux.org.uk> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.1 (1.2.1-4) Date: 10 Mar 2003 23:41:25 +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2003-01-26 at 20:58, Willem Riede wrote: > One of my ATAPI drives developed a real dislike to 2.5.55 and above, which gave > me plenty of opportunity to improve ide-scsi's error handling :-) . Cool. I've rewritten the do_reset logic in the 2.5.64-ac code so that it has a few less races > To handle ide device resets and be able to wait for them in the scsi context, I > have changed ide_do_reset and friends in drivers/ide/ide-iops.c to set the busy > flag on the hwgroup while the reset is in progress. Duplicated work, but I'm kind of happy because we both agreed on that part of the solution being safe 8) > I noticed, that ide-scsi didn't consistently use the printk priorities, so I > touched that up while I was at it. Thanks