From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E61C4321E for ; Fri, 7 Sep 2018 08:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 250B92077C for ; Fri, 7 Sep 2018 08:57:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 250B92077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728200AbeIGNhu convert rfc822-to-8bit (ORCPT ); Fri, 7 Sep 2018 09:37:50 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727529AbeIGNhu (ORCPT ); Fri, 7 Sep 2018 09:37:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74BC2804B4BA; Fri, 7 Sep 2018 08:57:52 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-123-84.rdu2.redhat.com [10.10.123.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0E4D2027EA4; Fri, 7 Sep 2018 08:57:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180906100220.4df8ac0e@canb.auug.org.au> References: <20180906100220.4df8ac0e@canb.auug.org.au> To: Stephen Rothwell Cc: dhowells@redhat.com, Al Viro , Linux-Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build warning after merge of the vfs tree MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <10475.1536310671.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Fri, 07 Sep 2018 09:57:51 +0100 Message-ID: <10476.1536310671@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 07 Sep 2018 08:57:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 07 Sep 2018 08:57:52 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Rothwell wrote: > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > security/selinux/hooks.c:2835:12: warning: 'selinux_sb_remount' defined but not used [-Wunused-function] > static int selinux_sb_remount(struct super_block *sb, void *data, size_t data_size) > ^~~~~~~~~~~~~~~~~~ > > Introduced by commit > > dfcf373eab92 ("vfs: Remove unused code after filesystem context changes") Sorry, I forgot to remove the function. It's no longer used, with the checks being done in selinux_validate_for_sb_reconfigure() now, called indirectly from the ->fs_context_validate() hook. David