From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 14 Mar 2003 17:04:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 14 Mar 2003 17:04:44 -0500 Received: from adsl-206-170-148-147.dsl.snfc21.pacbell.net ([206.170.148.147]:2578 "EHLO gw.goop.org") by vger.kernel.org with ESMTP id ; Fri, 14 Mar 2003 17:04:43 -0500 Subject: Re: 2.5.64-mm6: oops in elv_remove_request From: Jeremy Fitzhardinge To: Jens Axboe Cc: Linux Kernel List , Andrew Morton In-Reply-To: <20030314203324.GD791@suse.de> References: <1047576167.1318.4.camel@ixodes.goop.org> <20030313175454.GP836@suse.de> <1047578690.1322.17.camel@ixodes.goop.org> <20030313190247.GQ836@suse.de> <1047633884.1147.3.camel@ixodes.goop.org> <20030314203324.GD791@suse.de> Content-Type: text/plain Organization: Message-Id: <1047680131.1510.0.camel@ixodes.goop.org> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 14 Mar 2003 14:15:31 -0800 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2003-03-14 at 12:33, Jens Axboe wrote: > On Fri, Mar 14 2003, Jeremy Fitzhardinge wrote: > > With the version or cdrtools I compiled, I get an instant oops+lockup > > with the above command when running with anticipatory scheduler in > > 2.5.64-mm6 (hand written): > > > > elv_remove_request > > ide_end_request > > cdrom_end_request > > cdrom_decode_status > > cdrom_newpc_intr > > > --- drivers/block/as-iosched.c~ 2003-03-14 21:32:14.000000000 +0100 > +++ drivers/block/as-iosched.c 2003-03-14 21:32:38.000000000 +0100 > @@ -1341,6 +1341,8 @@ > insert_here = ad->dispatch->prev; > > list_add(&rq->queuelist, insert_here); > + if (arq) > + RB_CLEAR(&arq->rb_node); > > if (!list_empty(ad->dispatch) && rq_data_dir(rq) == READ > && (ad->antic_status == ANTIC_WAIT_REQ No joy, I'm afraid. Same crash. J