From: Robert Love <rml@tech9.net>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: akpm@digeo.com, Linux-kernel@vger.kernel.org,
torvalds@transmeta.com, ak@suse.de
Subject: Re: [PATCH] arch-independent syscalls to return long
Date: 21 Mar 2003 14:28:12 -0500 [thread overview]
Message-ID: <1048274891.4908.28.camel@phantasy.awol.org> (raw)
In-Reply-To: <1048274593.4908.26.camel@phantasy.awol.org>
On Fri, 2003-03-21 at 14:23, Robert Love wrote:
> I always that it did not matter, but Arjan just pointed out
> otherwise (as you saw). So I guess these need to be reverted.
And here is a patch to do so.
This patch, against 2.5.65 + the previous two, replaces the missing
asmlinkage on prototypes.
Robert Love
drivers/message/fusion/mptctl.c | 3 ++-
net/compat.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff -urN linux-2.5.65/drivers/message/fusion/mptctl.c linux/drivers/message/fusion/mptctl.c
--- linux-2.5.65/drivers/message/fusion/mptctl.c 2003-03-21 14:23:30.878772704 -0500
+++ linux/drivers/message/fusion/mptctl.c 2003-03-21 14:24:24.599605896 -0500
@@ -2743,7 +2743,8 @@
unsigned long,
struct file *));
int unregister_ioctl32_conversion(unsigned int cmd);
-extern long sys_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg);
+extern asmlinkage long sys_ioctl(unsigned int fd, unsigned int cmd,
+ unsigned long arg);
/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
/* sparc32_XXX functions are used to provide a conversion between
diff -urN linux-2.5.65/net/compat.c linux/net/compat.c
--- linux-2.5.65/net/compat.c 2003-03-21 14:23:31.000000000 -0500
+++ linux/net/compat.c 2003-03-21 14:25:03.000000000 -0500
@@ -365,8 +365,8 @@
kmsg->msg_control = (void *) orig_cmsg_uptr;
}
-extern long sys_setsockopt(int fd, int level, int optname,
- char *optval, int optlen);
+extern asmlinkage long sys_setsockopt(int fd, int level, int optname,
+ char *optval, int optlen);
static int do_netfilter_replace(int fd, int level, int optname,
char *optval, int optlen)
prev parent reply other threads:[~2003-03-21 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-21 6:11 Randy.Dunlap
2003-03-21 6:23 ` Andrew Morton
2003-03-21 6:39 ` Randy.Dunlap
2003-03-21 6:51 ` Robert Love
2003-03-21 18:46 ` Randy.Dunlap
2003-03-21 19:23 ` Robert Love
2003-03-21 19:28 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1048274891.4908.28.camel@phantasy.awol.org \
--to=rml@tech9.net \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@suse.de \
--cc=akpm@digeo.com \
--cc=rddunlap@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®