mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tiaan Wessels <tiaan@netsys.co.za>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: x.25 bug
Date: 28 Mar 2003 17:11:01 +0000	[thread overview]
Message-ID: <1048871461.5056.29.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <200303280600.h2S60YC02395@tiaan.netsys.co.za>

On Fri, 2003-03-28 at 06:00, Tiaan Wessels wrote:
> [X.] Other notes, patches, fixes, workarounds:
> in net/x25/x25_facilities.c function x25_parse_facilities
> there is switch with case X25_FAC_CLASS_D which has code
> 
> p   += p[1] + 2;
> len -= p[1] + 2;
> 
> the problem is in decrementing len, p is used after it was modified
> in previous statement. i suspect cut-and-paste here. to fix one
> would put p[1] in temp variable of unsigned char first and then use
> this instead of p[1] in these statements. if this is not done and
> a call arrives with class D facilities, we see a faint blinking of
> the eye before lights goes out.
> 
> can someone more familiar with the kernel patch process please update
> the latest sources.

PS: In the mean time if nobody else is looking at it, I'll take a look
at this bit too


      parent reply	other threads:[~2003-03-28 16:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-28  6:00 Tiaan Wessels
2003-03-28 17:10 ` Alan Cox
2003-03-28 17:11 ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1048871461.5056.29.camel@dhcp22.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiaan@netsys.co.za \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®