From: Robert Love <rml@tech9.net>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Wayne Whitney <whitney@math.berkeley.edu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] 2.5.65: Caching MSR_IA32_SYSENTER_CS kills dosemu
Date: 01 Apr 2003 17:16:59 -0500 [thread overview]
Message-ID: <1049235419.754.2.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.44.0304011320580.13867-100000@home.transmeta.com>
On Tue, 2003-04-01 at 16:28, Linus Torvalds wrote:
> Can you test this patch? It turns out that "get_cpu()/put_cpu()" are not
> enough - on UP they don't actually disable preemption, since the CPU
> number itself is perfectly stable at 0, of course.
Actually, do they do disable preemption - if they do not, something is
broken.
Because, even on UP, preemption can lead to a race over a variable that
has no locking because its per-CPU. But it would need locking
otherwise, and thus we do need to disable preemption. I.e., per-CPU
vars are only safe on SMP because we assume the other processors won't
touch them. If we start preempting, even on UP, we have problems.
So something else is amiss here...
Robert Love
next prev parent reply other threads:[~2003-04-01 22:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-31 19:13 Wayne Whitney
2003-03-31 19:27 ` Linus Torvalds
2003-03-31 23:58 ` Wayne Whitney
2003-04-01 0:13 ` Linus Torvalds
2003-04-01 3:28 ` Wayne Whitney
2003-04-01 21:28 ` Linus Torvalds
2003-04-01 22:16 ` Robert Love [this message]
2003-04-01 23:13 ` Linus Torvalds
2003-04-01 23:17 ` Robert Love
2003-04-02 0:33 ` Wayne Whitney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1049235419.754.2.camel@localhost \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=whitney@math.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®