From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: Jens Axboe <axboe@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] take 48-bit lba a bit further
Date: 06 Apr 2003 17:27:31 +0100 [thread overview]
Message-ID: <1049646450.1349.1.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030406164306.GC8303@vana.vc.cvut.cz>
On Sul, 2003-04-06 at 17:43, Petr Vandrovec wrote:
> > Works perfectly in testing here, ext2/3 generates nice big 512KiB
> > requests and the drive flies.
> >
> > (void) probe_lba_addressing(drive, 1);
> >
> > + if (drive->addressing)
> > + blk_queue_max_sectors(&drive->queue, 1024);
> > +
>
> Should not you honor host's max queue length? siimage & pdc4030 sets
> max_sectors to 128 (resp. 16 resp. 127), while you overwrite it here
> unconditionally with 1024.
For production code thats required. The actual change required is to
clamp the default/hwif set queue limit to 256 if driver->addressing !=1
next prev parent reply other threads:[~2003-04-06 17:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-06 13:07 Jens Axboe
2003-04-06 13:32 ` John Bradford
2003-04-06 13:32 ` Jens Axboe
2003-04-06 14:35 ` Alan Cox
2003-04-06 15:47 ` John Bradford
2003-04-06 15:59 ` Jens Axboe
2003-04-06 16:04 ` Jens Axboe
2003-04-06 16:08 ` John Bradford
2003-04-06 16:43 ` Petr Vandrovec
2003-04-06 16:27 ` Alan Cox [this message]
2003-04-07 7:50 ` Jens Axboe
[not found] <175955253@toto.iv>
2003-04-06 23:04 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1049646450.1349.1.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®