From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263106AbTDFVkI (for ); Sun, 6 Apr 2003 17:40:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263111AbTDFVkI (for ); Sun, 6 Apr 2003 17:40:08 -0400 Received: from smtp2.clear.net.nz ([203.97.37.27]:11465 "EHLO smtp2.clear.net.nz") by vger.kernel.org with ESMTP id S263106AbTDFVkH (for ); Sun, 6 Apr 2003 17:40:07 -0400 Date: Mon, 07 Apr 2003 09:48:35 +1200 From: Nigel Cunningham Subject: Re: PATCH: swsusp - 2.5.66 incremental In-reply-to: <20030406212931.GB693@elf.ucw.cz> To: Pavel Machek Cc: Linux Kernel Mailing List Message-id: <1049665714.9837.2.camel@laptop-linux.cunninghams> Organization: MIME-version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Content-type: text/plain Content-transfer-encoding: 7bit References: <1049537149.1709.6.camel@laptop-linux.cunninghams> <20030406182016.GA17666@atrey.karlin.mff.cuni.cz> <1049663561.3199.29.camel@laptop-linux.cunninghams> <20030406212931.GB693@elf.ucw.cz> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2003-04-07 at 09:29, Pavel Machek wrote: > Hi! > > > > You really should have moved it to the driver model... having #ifdef > > > in suspend.c for every driver would be very ugly. > > > > Sorry. I thought that was the maintainer's job. > > Well, his job is to tell you to do it properly. Don't expect him to do > the rewriting himself. [Also he probably is not using swsusp so he > would not test that.] Pavel Ah. Okay. So I learn something else about the way kernel develepment works... the maintainer doesn't actually maintain the code! Guess I need to learn the driver model stuff. Regards, Nigel