From: Nigel Cunningham <ncunningham@clear.net.nz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Fixes for ide-disk.c
Date: Mon, 07 Apr 2003 09:58:57 +1200 [thread overview]
Message-ID: <1049666337.9837.11.camel@laptop-linux.cunninghams> (raw)
In-Reply-To: <1049662835.1600.31.camel@dhcp22.swansea.linux.org.uk>
On Mon, 2003-04-07 at 09:00, Alan Cox wrote:
> There are multiple "blocked" fields to deal with. drive->blocked
> indicates we can't feed it commands because it is blocked due to
> power management.
>
> idedisk_suspend sets the drive->blocked field so that we panic if
> anything is sent to the disk after we turned it off (since it
> would be a corrupter).
>
> idedisk_resume is called on the resume path and marks the drive
> as safe to use.
>
> So if you hit that bug, you did I/O after shutting the drive down,
> which is not allowed.
Okay. So the right behaviour is to ignore multiple idedisk_suspend calls
and ignore multiple idedisk_resume calls?
Regards,
Nigel
--
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand
Be diligent to present yourself approved to God as a workman who does
not need to be ashamed, handling accurately the word of truth.
-- 2 Timothy 2:14, NASB.
next prev parent reply other threads:[~2003-04-06 21:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-05 7:31 Nigel Cunningham
2003-04-05 9:27 ` John Bradford
2003-04-05 10:57 ` Andre Hedrick
2003-04-05 13:09 ` John Bradford
2003-04-05 16:46 ` Alan Cox
2003-04-05 19:25 ` Nigel Cunningham
2003-04-05 20:58 ` Andre Hedrick
2003-04-06 15:03 ` Alan Cox
2003-04-06 20:59 ` Nigel Cunningham
2003-04-06 21:02 ` Alan Cox
2003-04-06 21:12 ` Nigel Cunningham
2003-04-06 21:00 ` Alan Cox
2003-04-06 21:58 ` Nigel Cunningham [this message]
2003-04-10 18:38 ` Pavel Machek
2003-04-10 21:55 ` Alan Cox
2003-04-10 23:36 ` Nigel Cunningham
2003-04-13 11:17 ` Pavel Machek
2003-04-10 18:37 ` Pavel Machek
2003-04-11 3:30 ` Andre Hedrick
2003-04-05 16:46 ` Alan Cox
2003-04-05 10:32 Chuck Ebbert
2003-04-05 11:30 ` Andre Hedrick
2003-04-05 18:34 Mudama, Eric
2003-04-05 19:52 ` Andre Hedrick
2003-04-05 20:17 Mudama, Eric
2003-04-05 20:54 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1049666337.9837.11.camel@laptop-linux.cunninghams \
--to=ncunningham@clear.net.nz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®