From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262960AbTDIJ5t (for <rfc822;willy@w.ods.org>); Wed, 9 Apr 2003 05:57:49 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262966AbTDIJ5t (for <rfc822;linux-kernel-outgoing>); Wed, 9 Apr 2003 05:57:49 -0400
Received: from griffon.mipsys.com ([217.167.51.129]:41979 "EHLO
	zion.wanadoo.fr") by vger.kernel.org with ESMTP id S262960AbTDIJ5s (for <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Apr 2003 05:57:48 -0400
Subject: Re: Linux 2.4.21-pre7
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: mikpe@csd.uu.se
Cc: Kaj-Michael Lang <milang@tal.org>,
       Marcelo Tosatti <marcelo@conectiva.com.br>,
       linuxppc-dev@lists.linuxppc.org, lkml <linux-kernel@vger.kernel.org>
In-Reply-To: <16019.60959.273586.121431@gargle.gargle.HOWL>
References: <Pine.LNX.4.53L.0304041815110.32674@freak.distro.conectiva>
	 <00b101c2fdeb$e1aa6e20$56dc10c3@amos>
	 <16019.60959.273586.121431@gargle.gargle.HOWL>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: 
Message-Id: <1049882960.559.35.camel@zion.wanadoo.fr>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.3 
Date: 09 Apr 2003 12:09:24 +0200
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2003-04-09 at 11:55, mikpe@csd.uu.se wrote:
> Kaj-Michael Lang writes:
>  > > So here goes -pre7. Hopefully the last -pre.
>  > >
>  > Won't compile for my PPC:
>  > ---
>  >         -o vmlinux
>  > drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
>  > : undefined reference to `io_flush'
>  > drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
>  > : relocation truncated to fit: R_PPC_REL24 io_flush
> 
> Someone updated pmac.c without testing it: io_flush() doesn't exist
> in 2.4.21-pre. Based on the diff from -pre6 to -pre7, I'd say the
> following is a reasonable approximation. My PM4400 runs with this
> patch right now.

Or just get my devel rsync.

Actually, what happened is that Marcelo took the version that was
in -ac tree, which I sent to Alan a while ago and is now outdated.
The io_flush macro was something I added to the arch includes and
later removed as I fixed the problem differently.

Marcelo: I sent you a fixed version, please do not apply this patch
but rather the one I sent you.

Ben.