From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] M68k IDE updates
Date: 13 Apr 2003 15:10:03 +0100 [thread overview]
Message-ID: <1050243002.24186.7.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <200304131306.h3DD6XQ3001331@callisto.of.borg>
On Sul, 2003-04-13 at 14:06, Geert Uytterhoeven wrote:
> +#ifdef M68K_IDE_SWAPW
> + if (M68K_IDE_SWAPW) { /* fix bus byteorder first */
> + u_char *p = (u_char *)id;
> + u_char t;
> + for (i = 0; i < 512; i += 2) {
> + t = p[i];
> + p[i] = p[i+1];
> + p[i+1] = t;
> + }
> + }
> +#endif
This looks the wrong place to fix this problem Geert. The PPC
folks have the same issues with byte order on busses but you
won't see ifdefs in the core IDE code for it.
Fix your __ide_mm_insw/ide_mm_outsw macros and the rest happens
automatically.
Linus, until better justification of why this has to be here
can you not apply this change.
Alan
next prev parent reply other threads:[~2003-04-13 14:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-13 13:06 Geert Uytterhoeven
2003-04-13 14:10 ` Alan Cox [this message]
2003-04-13 23:43 ` Paul Mackerras
2003-04-14 8:39 ` Geert Uytterhoeven
2003-04-14 9:19 ` Benjamin Herrenschmidt
2003-04-14 9:24 ` Geert Uytterhoeven
2003-04-14 12:19 ` Alan Cox
2003-04-14 12:21 ` Alan Cox
2003-04-14 13:44 ` Geert Uytterhoeven
2003-04-14 16:03 ` Alan Cox
2003-04-15 4:45 ` Jamie Lokier
2003-04-15 8:11 ` Geert Uytterhoeven
2003-04-15 9:23 ` Jörn Engel
2003-04-15 9:52 ` Geert Uytterhoeven
2003-04-14 12:48 ` Alan Cox
2003-04-14 12:48 ` Alan Cox
2003-04-14 17:44 ` Linus Torvalds
2003-04-14 19:54 ` Geert Uytterhoeven
2003-04-14 22:31 ` Paul Mackerras
2003-04-15 8:14 ` Geert Uytterhoeven
2003-04-21 16:55 ` Geert Uytterhoeven
2003-04-22 14:49 ` Alan Cox
2003-04-22 13:55 Mudama, Eric
[not found] <Pine.GSO.4.21.0304221802570.16017-100000@vervain.sonytel.be>
2003-04-23 11:27 ` Richard Zidlicky
2003-04-23 11:04 ` Alan Cox
2003-04-23 20:19 ` John Bradford
2003-04-24 9:47 ` Richard Zidlicky
2003-04-24 11:26 ` Geert Uytterhoeven
2003-04-24 13:14 ` Richard Zidlicky
2003-04-24 14:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1050243002.24186.7.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®