From: Valdis.Kletnieks@vt.edu
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, chris.mason@oracle.com,
josef@redhat.com, agruen@linbit.com,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH 1/4] Cache xattr security drop check for write
Date: Sun, 29 May 2011 13:48:26 -0400 [thread overview]
Message-ID: <105043.1306691306@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sun, 29 May 2011 07:24:32 PDT." <20110529142432.GA7103@alboin.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Sun, 29 May 2011 07:24:32 PDT, Andi Kleen said:
> These are not for selinux xattrs, but capability xattrs.
+#define S_NOSEC 4096 /* no suid or xattr security attributes */
Sorry for reading that wrong, since selinux stores stuff under security.* xattr
as well.
+ int issec = !strncmp(name, XATTR_SECURITY_PREFIX,
+ XATTR_SECURITY_PREFIX_LEN);
is going to match *any* security.* attribute, including SELinux ones stored under
security.selinux. If you wanted to be capability-specific, maybe youw anted these
two:
#define XATTR_CAPS_SUFFIX "capability"
#define XATTR_NAME_CAPS XATTR_SECURITY_PREFIX XATTR_CAPS_SUFFIX
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
prev parent reply other threads:[~2011-05-29 17:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 22:54 Andi Kleen
2011-05-27 22:54 ` [PATCH 2/4] EXT4: Set NOSEC flag early when there are no xattrs Andi Kleen
2011-05-28 9:08 ` Marco Stornelli
2011-05-28 11:24 ` Chris Mason
2011-05-28 14:43 ` Andi Kleen
2011-05-27 22:54 ` [PATCH 3/4] BTRFS: Set NOSEC early for btrfs Andi Kleen
2011-05-27 22:54 ` [PATCH 4/4] XFS: Set NOSEC flag early when inode has no xattrs Andi Kleen
2011-05-28 11:42 ` [PATCH 1/4] Cache xattr security drop check for write Al Viro
2011-05-29 13:52 ` Valdis.Kletnieks
2011-05-29 14:24 ` Andi Kleen
2011-05-29 17:48 ` Valdis.Kletnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=105043.1306691306@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=agruen@linbit.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®