mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	linux-rtc@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH 2/2] m68k: introduce a virtual m68k machine
Date: Fri, 1 Oct 2021 11:08:23 +1000 (AEST)	[thread overview]
Message-ID: <1050733c-5260-3c1e-1ecc-7d3b58683a88@linux-m68k.org> (raw)
In-Reply-To: <7748de16-1087-1039-a1cc-5a94dc293dbb@vivier.eu>

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

On Thu, 30 Sep 2021, Laurent Vivier wrote:

> Le 30/09/2021 à 22:56, John Paul Adrian Glaubitz a écrit :
> > 
> > On 4/28/21 14:15, Laurent Vivier wrote:
> >>> I have tested and reviewed your patch, great work!
> >>> I'm confident this can make v5.14, with the small nits fixed.
> >>
> >> Thank you for your review.
> >>
> >> I will answer to some of your comments and update accordingly my patch.
> > 
> > It looks like this patch somehow fell off the table, didn't it?
> > 
> > I was hoping to be able to build a virt kernel for Debian/m68k by default
> > in the near future.
> 
> Yes, I started to update my work according to the comments from Geert but didn't have time to finish.
> 
> Especially I tried to remove the LEGACY_TIMER_TICK, but it doesn't work, 

There was an RFC patch from Arnd to convert the mac platform from 
LEGACY_TIMER_TICK to GENERIC_CLOCKEVENTS:
https://lore.kernel.org/linux-m68k/20201008154651.1901126-14-arnd@arndb.de/
Arnd used a periodic clockevent device. I have a developmental branch 
based on that patch.

Alternatively, I have a branch that implements a oneshot clockevent 
device. This delivers GENERIC_CLOCKEVENTS and NO_HZ. For this I used VIA 1 
timer 1 in free-running mode for the clocksource and VIA 1 timer 2 in 
one-shot mode for the clockevent device. (But this does require some QEMU 
improvements because there's no oneshot-mode in mos6522.c in mainline 
QEMU.)

Anyway, it can be done. If you want to pursue it, perhaps we can 
collaborate.

> and as it has been tested like this by you and most of the other m68k 
> targets uses it I think I will let the patch with it.
> 
> I'm going to update my patch to have a v2, at least to have fresh 
> reviews.
> 
> Thanks,
> Laurent
> 

  reply	other threads:[~2021-10-01  1:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 22:14 [PATCH 0/2] m68k: Add Virtual M68k Machine Laurent Vivier
2021-03-23 22:14 ` [PATCH 1/2] rtc: goldfish: remove dependency to OF Laurent Vivier
2021-03-23 22:14 ` [PATCH 2/2] m68k: introduce a virtual m68k machine Laurent Vivier
2021-04-27 17:20   ` Laurent Vivier
2021-04-28 12:07     ` Geert Uytterhoeven
2021-04-28 12:15       ` Laurent Vivier
2021-09-30 20:56         ` John Paul Adrian Glaubitz
2021-09-30 21:01           ` Laurent Vivier
2021-10-01  1:08             ` Finn Thain [this message]
2021-04-28 12:04   ` Geert Uytterhoeven
2021-04-28 23:06     ` Josh Juran
2021-04-29  7:23       ` Geert Uytterhoeven
2021-09-30 21:11     ` Laurent Vivier
2021-09-30 21:14       ` John Paul Adrian Glaubitz
2021-04-16 20:26 ` [PATCH 0/2] m68k: Add Virtual M68k Machine Alexandre Belloni
2021-04-16 20:34   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1050733c-5260-3c1e-1ecc-7d3b58683a88@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=laurent@vivier.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®