mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andries.Brouwer@cwi.nl
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hpt366.c compilation fix
Date: 20 Apr 2003 19:44:24 +0100	[thread overview]
Message-ID: <1050864264.11658.2.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <UTC200304201823.h3KINFi18073.aeb@smtp.cwi.nl>

On Sul, 2003-04-20 at 19:23, Andries.Brouwer@cwi.nl wrote:
> Remove declaration of unused variables.
> 
> diff -u --recursive --new-file -X /linux/dontdiff a/drivers/ide/pci/hpt366.c b/drivers/ide/pci/hpt366.c
> --- a/drivers/ide/pci/hpt366.c	Sun Apr 20 12:59:31 2003
> +++ b/drivers/ide/pci/hpt366.c	Sun Apr 20 20:11:59 2003
> @@ -1105,7 +1105,6 @@
>  		    (findev->device == dev->device) &&
>  		    ((findev->devfn - dev->devfn) == 1) &&
>  		    (PCI_FUNC(findev->devfn) & 1)) {
> -			u8 irq = 0, irq2 = 0;
>  			if (findev->irq != dev->irq) {
>  				/* FIXME: we need a core pci_set_interrupt() */
>  				findev->irq = dev->irq;

Well it compiles regardless but yes that seems right to me


  reply	other threads:[~2003-04-20 19:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-20 18:23 Andries.Brouwer
2003-04-20 18:44 ` Alan Cox [this message]
2003-04-20 18:56 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1050864264.11658.2.camel@dhcp22.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®