From: "David S. Miller" <davem@redhat.com>
To: azarah@gentoo.org
Cc: KML <linux-kernel@vger.kernel.org>
Subject: Re: Re:[2.5] Update sk98lin driver
Date: 04 May 2003 17:48:22 -0700 [thread overview]
Message-ID: <1052095702.27465.19.camel@rth.ninka.net> (raw)
In-Reply-To: <1052092571.4459.27.camel@nosferatu.lan>
On Sun, 2003-05-04 at 16:56, Martin Schlemmer wrote:
> A few issues though:
>
> 1) Should MOD_INC_USE_COUNT and MOD_DEC_USE_COUNT just be removed?
> I commented them for now.
No. For the net device itself, make sure you do
SET_MODULE_OWNER() on the netdev before passing it
to register_netdevice().
For the procfs stuff you must make sure the appropriate
module refcounting is done for that mechanism.
Just deleteing MOD_{INC,DEC}_USE_COUNT blindly will result
in the module being broken.
--
David S. Miller <davem@redhat.com>
prev parent reply other threads:[~2003-05-05 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-04 21:30 Xose Vazquez Perez
2003-05-04 23:56 ` Martin Schlemmer
2003-05-05 0:48 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1052095702.27465.19.camel@rth.ninka.net \
--to=davem@redhat.com \
--cc=azarah@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®