mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Jens Axboe <axboe@suse.de>
Cc: "Nicolas Pitre" <nico@cam.org>,
	"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	"Russell King" <rmk@arm.linux.org.uk>,
	"Jörn Engel" <joern@wohnheim.fh-wedel.de>,
	"Marcus Meissner" <meissner@suse.de>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Only use MSDOS-Partitions by default on X86
Date: Tue, 06 May 2003 22:01:28 +0100	[thread overview]
Message-ID: <1052254888.7532.58.camel@imladris.demon.co.uk> (raw)
In-Reply-To: <20030506184914.GL905@suse.de>

On Tue, 2003-05-06 at 19:49, Jens Axboe wrote:
> I see, that would indeed be a bigger job :). Just the block layer would
> not be hard, especially if you make the restriction that the block
> drivers usable would be ones that used a make_request strategy for
> handling requests. That would allow you to kill ll_rw_blk.c,
> deadline-iosched.c, and elevator.c. That's some 21k of text and 2k of
> data on this box.

That's a little short of what I was intending. Ideally we stick 'struct
request', 'struct buffer_head' and 'struct bio' inside #ifdef
CONFIG_BLK_DEV, then kill all the dead code which uses them.

block_dev.c becomes...

int blkdev_open(struct inode * inode, struct file * filp)
{
	return -ENXIO;
}

Don't look at JFFS; that still needs to be able to open a block device
even though it never actually _uses_ it. Look at the non-blkdev mount
path for JFFS2 instead. The _only_ thing we use the mtdblock device for
is to look at its minor number and use it to pick the right MTD device
-- it used to give us the locking on simultaneous mounts for free, a
constant device number for NFS exporting, and a cheap way to work around
the bug that the 'root=' command line option isn't available to
filesystems directly.

mtdblock.c cleanup noted with interest -- I'll play with that shortly;
thanks. Note that you don't actually need flash hardware, you can load
the 'mtdram' device which fakes it with vmalloc-backed storage instead.
Not too useful for powerfail-testing but for mounting something like
ext2 on mtdblock on mtdram it's fine.

-- 
dwmw2



  parent reply	other threads:[~2003-05-06 20:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030505210811.GC7049@wohnheim.fh-wedel.de.suse.lists.linux.kernel>
     [not found] ` <1052218090.28792.15.camel@dhcp22.swansea.linux.org.uk.suse.lists.linux.kernel>
     [not found]   ` <20030506120939.GB15261@wohnheim.fh-wedel.de.suse.lists.linux.kernel>
2003-05-06 12:28     ` Marcus Meissner
2003-05-06 12:42       ` Jörn Engel
2003-05-06 14:03         ` Russell King
2003-05-06 15:32           ` Jörn Engel
2003-05-06 17:13             ` Russell King
2003-05-06 17:23               ` Nicolas Pitre
2003-05-06 17:26                 ` Alan Cox
2003-05-06 18:30                   ` Jens Axboe
2003-05-06 18:42                     ` Nicolas Pitre
2003-05-06 18:49                       ` Jens Axboe
2003-05-06 19:10                         ` Nicolas Pitre
2003-05-06 19:20                           ` Jens Axboe
2003-05-06 19:54                             ` Jens Axboe
2003-05-06 21:01                         ` David Woodhouse [this message]
2003-05-07  7:22                           ` Jens Axboe
2003-05-07  7:41                             ` David Woodhouse
2003-05-07  7:43                               ` Jens Axboe
2003-05-06 17:42                 ` [PATCH] Only use MS-DOS-Partitions " Riley Williams
2003-05-05 21:08 [PATCH] Only use MSDOS-Partitions " Jörn Engel
2003-05-06 10:48 ` Alan Cox
2003-05-06 12:09   ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1052254888.7532.58.camel@imladris.demon.co.uk \
    --to=dwmw2@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=axboe@suse.de \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=meissner@suse.de \
    --cc=nico@cam.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®