From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756617AbbLDVbr (ORCPT ); Fri, 4 Dec 2015 16:31:47 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:60152 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754691AbbLDVbq (ORCPT ); Fri, 4 Dec 2015 16:31:46 -0500 From: Arnd Bergmann To: Eric Dumazet Cc: Gregory CLEMENT , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Thomas Petazzoni , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Lior Amsalem , Nadav Haklai , Marcin Wojtas , Simon Guinot , Maxime Ripard , Boris BREZILLON , Russell King - ARM Linux , Willy Tarreau Subject: Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues management on all CPUs Date: Fri, 04 Dec 2015 22:30:35 +0100 Message-ID: <10523514.jXrVKo414l@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1449256350.25029.36.camel@edumazet-glaptop2.roam.corp.google.com> References: <1449254700-32685-1-git-send-email-gregory.clement@free-electrons.com> <1449254700-32685-5-git-send-email-gregory.clement@free-electrons.com> <1449256350.25029.36.camel@edumazet-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:cTEHEGVgyzdVQgrhxwtgMBL382ot6FwsK1J83L5fmGAREgg+aVU HHKgNTaj13O8zeMmyTivAm1cLtiDlOJO+J5qH+8ge3/dtwgkJqeJd61AOjMEtguSvo81C5x 8naRPhfTf0PIJBFDik5ovyPMJ8QCDtaYpo4fX3ET9yKO9r2Go8MPlskFreGedBQG7DejAsG NtWcBF4U8hUepR3baQSaA== X-UI-Out-Filterresults: notjunk:1;V01:K0:5o1pgPVLXsA=:Zj0zpB/ItshvpYar/XzpnG NQ7wunosnUki8pJVg4wRCb/pzQxcS+GikilQoYq6ValZCgKsZYE4VaKu2ibEZEfZXoPDUEh69 m1Nr/9C8vxtCjOs+WtjHcPEZzvxJK0ZtfENQzi4n3m3wO1Oqd7Y1p8N+fxAgcEXjEAlM1f7Lc fM+yoq7BjPvQD+8qhqHbekGuErgeDVTlyevgdqIatq8nN1VFdYzvO3BaSwWBwmXEk+UNDf3tL O1nk/AcsfB1EV9RZcV5Op4veappqFXLDibsG3GQrwD3AsZRrFFxhkoGyuoqOPDX05MO4SlU8y VJtTkdv2A8ELnB5A0JyCEcu2oNXS/6tR1PKWazeUmyhX6rZ14ebWy1NMFMbzbf2wlUBdVDZtb PVm7ASTN16zA+Ex2dgLLBsnocP6UiubVz8i8DDrX4uopaS7wP4wRD8taGCUdPgeCvqKCogsgX Wn3WwEdrdJEWtU09RGmfc3K6irY4l3TyNkYwuH9pJzZEtW2KwLct+TeGltittyi6iUURVlZfj NWBk+zN4oT2ZYqNHxZz5hTnYEO7aKNDrvPRMvhemCbat7khpUfIHx6lJQzx4Pu6vjWFfIsFIm 2S59o1KOpaaB4vGoauB+Ry3rIDx139GsMNA+Zxqye4oM2TvrD8n15bKTviqMlI4UL9Pg1RTv3 5yyv4w52+BW1RHDfoN7R337e1bg+X3OVXChT/UGkPZy5JhXnPVVaUXMD/8H3Cwj93kB4Rh3VT moqmXHJj08WtZujm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 04 December 2015 11:12:30 Eric Dumazet wrote: > On Fri, 2015-12-04 at 19:45 +0100, Gregory CLEMENT wrote: > > With this patch each CPU is associated with its own set of TX queues. In > > the same time the SKB received in mvneta_tx is bound to the queue > > associated to the CPU sending the data. Thanks to this the next IRQ will > > be received on the same CPU allowing sending more data. > > > > It will also allow to have a more predictable behavior regarding > > throughput and latency when having multiple threads sending out data on > > different CPUs. > > > > As an example on Armada XP GP, with an iperf bound to a CPU and a ping > > bound to another CPU, without this patch the ping round trip was about > > 2.5ms (and could reach 3s!), whereas with this patch it was around > > 0.7ms (and sometime it went to 1.2ms). > > This really looks like you need something smarter than pfifo_fast qdisc, > and maybe BQL (I did not check if this driver already implements this) I suggested this change as well as the BQL implementation that Marcin did. I believe he hasn't posted that yet while he's doing some more testing, but it should come soon. Arnd