From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bernhard Kaindl <bk@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Bernhard Kaindl <bernhard.kaindl@gmx.de>
Subject: Re: [PATCH][2.4] cleanup ptrace secfix and fix most side effects
Date: 08 May 2003 22:31:37 +0100 [thread overview]
Message-ID: <1052429495.13567.7.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0305082310230.12720-200000@wotan.suse.de>
On Iau, 2003-05-08 at 23:05, Bernhard Kaindl wrote:
> - mb();
> - if (!is_dumpable(child))
> - return -EPERM;
>
> if (!(child->ptrace & PT_PTRACED))
> return -ESRCH;
>
> Using is_dumpable() here is not neccesary because the checks done here are:
>
> > if (!(child->ptrace & PT_PTRACED))
> > return -ESRCH;
Except that current->mm->dumpable is not per task but per mm so you
might ptrace one thread and have another go setuid.
next prev parent reply other threads:[~2003-05-08 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-08 22:05 Bernhard Kaindl
2003-05-08 21:31 ` Alan Cox [this message]
2003-05-08 22:48 ` Alan Cox
2003-05-08 23:59 ` Bernhard Kaindl
2003-05-09 0:17 ` Bernhard Kaindl
2003-05-10 20:52 ` ptrace secfix does NOT work... :( Adam Majer
2003-05-10 21:11 ` Daniel Jacobowitz
2003-05-10 21:25 ` Adam Majer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1052429495.13567.7.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bernhard.kaindl@gmx.de \
--cc=bk@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®