On Mon, 2003-05-12 at 22:19, David Mosberger wrote: > >>>>> On 12 May 2003 21:48:31 +0200, Michel Dänzer said: > > >> using an old kernel that doesn't have asm/agp.h yet?). > > Michel> That's it. > > OK, thanks for clarifying. > > Michel> So we have to check the version before #including > Michel> . Then, we can do something like > > Michel> #ifndef PAGE_AGP #define PAGE_AGP PAGE_KERNEL_NOCACHE #endif > > Michel> Or am I missing something? > > Basically correct, except that the patch also needs an improved > version of vmap(), which was introduced in 2.5.68 only (IIRC). I'll > update my patch so it is a no-op unless you have a kernel >= 2.5.68. Hmm, isn't there a way to make it work with older kernels as well? For reference, we've been using http://www.penguinppc.org/~daenzer/DRI/drm-ioremapagp.diff by Benjamin Herrenschmidt for a while for Apple UniNorth northbridges. I was hoping to replace it with a cleaner solution like yours. Anyway, after applying your second patch, things looked much better, and the attached patch against the DRI CVS trunk builds without warnings here. -- Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer