mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH for 6.13 v1 4/8] thermal: core: Initialize thermal zones before registerimg them
Date: Tue, 10 Sep 2024 11:31:19 +0200	[thread overview]
Message-ID: <10527854.nUPlyArG6x@rjwysocki.net> (raw)
In-Reply-To: <4920970.GXAFRqVoOG@rjwysocki.net>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Since user space can start interacting with a new thermal zone as soon
as device_register() called by thermal_zone_device_register_with_trips()
returns, it is better to initialize the thermal zone before calling
device_register() on it.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/thermal/thermal_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/thermal/thermal_core.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_core.c
+++ linux-pm/drivers/thermal/thermal_core.c
@@ -1469,6 +1469,7 @@ thermal_zone_device_register_with_trips(
 		thermal_zone_destroy_device_groups(tz);
 		goto remove_id;
 	}
+	thermal_zone_device_init(tz);
 	result = device_register(&tz->device);
 	if (result)
 		goto release_device;
@@ -1507,7 +1508,6 @@ thermal_zone_device_register_with_trips(
 
 	mutex_unlock(&thermal_list_lock);
 
-	thermal_zone_device_init(tz);
 	/* Update the new thermal zone and mark it as already updated. */
 	if (atomic_cmpxchg(&tz->need_update, 1, 0))
 		thermal_zone_device_update(tz, THERMAL_EVENT_UNSPECIFIED);




  parent reply	other threads:[~2024-09-10  9:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10  9:26 [PATCH for 6.13 v1 0/8] thermal: core: Updates related to thermal instances, trip points handling and locking Rafael J. Wysocki
2024-09-10  9:27 ` [PATCH for 6.13 v1 1/8] thermal: core: Move lists of thermal instances to trip descriptors Rafael J. Wysocki
2024-09-10  9:28 ` [PATCH for 6.13 v1 2/8] thermal: core: Pass trip descriptors to trip bind/unbind functions Rafael J. Wysocki
2024-09-10  9:30 ` [PATCH for 6.13 v1 3/8] thermal: core: Build sorted lists instead of sorting them later Rafael J. Wysocki
2024-09-10  9:31 ` Rafael J. Wysocki [this message]
2024-09-10  9:32 ` [PATCH for 6.13 v1 5/8] thermal: core: Rename trip list node in struct thermal_trip_desc Rafael J. Wysocki
2024-09-10  9:33 ` [PATCH for 6.13 v1 6/8] thermal: core: Add function for moving trips to sorted lists Rafael J. Wysocki
2024-09-10  9:34 ` [PATCH for 6.13 v1 7/8] thermal: core: Use trip lists for trip crossing detection Rafael J. Wysocki
2024-09-10  9:35 ` [PATCH for 6.13 v1 8/8] thermal: core: Add and use thermal zone guard Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10527854.nUPlyArG6x@rjwysocki.net \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®