From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: jcwren@jcwren.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Machin dependent serial port patches
Date: 20 May 2003 13:09:11 +0100 [thread overview]
Message-ID: <1053432549.30546.5.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <200305192056.00610.jcwren@jcwren.com>
On Maw, 2003-05-20 at 01:56, J.C. Wren wrote:
> One of the things I noticed in the port of 2.5.69 to the 386EX embedded
> system is that serial.h appears to not be a mach-xxx positionable file. The
> 386EX board uses standard 8250 type serial ports, but at 3.6864Mhz instad of
> 1.8432Mhz. There appears to be no way to build a patch set without modifying
> include/i386/serial.h. Would this not be better places in mach-defaults?
> I'm trying very hard to modify as few files as possible when building these
> patch sets.
Making asm-i386/serial.h include a mach- file sounds the right thing to
do. mach- for x86 is pretty new so a lot of stuff that maybe should be
in it, hasnt migrated yet.
The counter argument however is that you should be able to use setserial
to adjust the baud base so you dont need to change anything 8)
next prev parent reply other threads:[~2003-05-20 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-20 0:56 J.C. Wren
2003-05-20 12:09 ` Alan Cox [this message]
2003-05-20 13:57 ` J.C. Wren
2003-05-28 9:44 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1053432549.30546.5.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jcwren@jcwren.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®