From: David Woodhouse <dwmw2@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Michael Hunold <hunold@convergence.de>, linux-kernel@vger.kernel.org
Subject: Re: [RFC][2.5] generic_usercopy() function (resend, forgot the patches)
Date: Sun, 25 May 2003 12:23:40 +0100 [thread overview]
Message-ID: <1053861820.2082.36.camel@passion.cambridge.redhat.com> (raw)
In-Reply-To: <20030523104722.B15725@infradead.org>
On Fri, 2003-05-23 at 10:47, Christoph Hellwig wrote:
> > + err = func(inode, file, cmd, parg);
> > + if (err == -ENOIOCTLCMD)
> > + err = -EINVAL;
>
> I don't think this is the right place for this substitution - leave it to
> the drivers.
And make it -ENOTTY. -EINVAL is not correct for unknown ioctls.
--
dwmw2
next prev parent reply other threads:[~2003-05-25 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 9:37 Michael Hunold
2003-05-23 9:47 ` Christoph Hellwig
2003-05-23 10:10 ` Michael Hunold
2003-05-23 10:19 ` Christoph Hellwig
2003-05-23 11:49 ` Gerd Knorr
2003-05-25 11:23 ` David Woodhouse [this message]
2003-05-23 11:17 ` Ingo Oeser
2003-05-30 0:25 ` David Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1053861820.2082.36.camel@passion.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=hunold@convergence.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®