From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 518423563F8 for ; Tue, 18 Nov 2025 14:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763475067; cv=none; b=F/8s306jdbGoiL4zCIkm/ZsZPZ+Q43B+t2y1Bcd8AtoSaqHI6FYWhrRvuiZSz+xI2nMP8EQxNsCt/E6z2x1l55SgXPzbrhIVHms09PfF729NdNKkJ7tfE66UkEsZfykfAMWT3Gehe2tI25Fmr4AiHjW9yLphaHFweiRfohVn2GU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763475067; c=relaxed/simple; bh=PQud6e92thFB9c6Au+YY3nmgq5hbNd84jqohl6Xni4c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A9WJYzT2TTViFIIYwm8gmPyYPWrw6cMdKvT3FRNyOvSo9zViP7TFqF+EAZNlmS1uY7F6sWO59Mvt7a33W/p+g5mz108uUElc+Zw2a1cDefEJedW/36efJs1Q1MtH4SGjIzmo89x+uFA9xtde0yIS9uZZHpOi3jlTrUfV4Goec3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=WYSAedWI; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="WYSAedWI" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 839BCC12677; Tue, 18 Nov 2025 14:10:40 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id AA111606FE; Tue, 18 Nov 2025 14:11:02 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3318710371867; Tue, 18 Nov 2025 15:11:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763475062; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=fEyc8tBhzMb3rXZXOABx0llI2kXfmiLR4TsCiclkMc0=; b=WYSAedWIp7vQsJdM+ma5o74b/uVpOUFKFpX0F6z5nFZuFswh0GZxndiGHZP9lwwXXBWqqF wUt7U1GRXDGRXpCOYq7SB2te3Af2PmyPWr6Gfo9sNz4Bss04ZconS0xwbHvsqjmgbb1AhQ eJaBS5vGZ90+oNyDKbe+WvEHAP38O+h14ICPMhB2RfRyC7ui7I5hu3r1EJl1XSihC/wh98 Vw5HnA8ijaEF8OZLI18PkNj7lTrg82Vn4eeL/wI5t45wwKs0Vt05DcvOwUTvFgUojwRv4z fj7KPN++DIsdKFikYM7jJDv71wQ8MRzCS0o4ip3LrVpTaNXdbVsu4eUJqafsZA== Message-ID: <10541c3d-07b8-4dd7-8a17-b122b1b81996@bootlin.com> Date: Tue, 18 Nov 2025 15:10:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: dsa: yt921x: Fix MIB attribute table To: David Yang , netdev@vger.kernel.org Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org References: <20251118091237.2208994-1-mmyangfl@gmail.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20251118091237.2208994-1-mmyangfl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi David, On 18/11/2025 10:12, David Yang wrote: > There are holes in the MIB field I didn't notice, leading to wrong > statistics after stress tests. > > Signed-off-by: David Yang Even if this is fixing a patch that's still in net-next, you may want to add a fixes tag, as this is a bugfix :/ Maxime > --- > drivers/net/dsa/yt921x.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c > index 944988e29127..97fc6085f4d0 100644 > --- a/drivers/net/dsa/yt921x.c > +++ b/drivers/net/dsa/yt921x.c > @@ -56,13 +56,13 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = { > > MIB_DESC(1, 0x30, NULL), /* RxPktSz1024To1518 */ > MIB_DESC(1, 0x34, NULL), /* RxPktSz1519ToMax */ > - MIB_DESC(2, 0x38, NULL), /* RxGoodBytes */ > - /* 0x3c */ > + /* 0x38 unused */ > + MIB_DESC(2, 0x3c, NULL), /* RxGoodBytes */ > > - MIB_DESC(2, 0x40, "RxBadBytes"), > - /* 0x44 */ > - MIB_DESC(2, 0x48, NULL), /* RxOverSzErr */ > - /* 0x4c */ > + /* 0x40 */ > + MIB_DESC(2, 0x44, "RxBadBytes"), > + /* 0x48 */ > + MIB_DESC(1, 0x4c, NULL), /* RxOverSzErr */ > > MIB_DESC(1, 0x50, NULL), /* RxDropped */ > MIB_DESC(1, 0x54, NULL), /* TxBroadcast */ > @@ -79,10 +79,10 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = { > MIB_DESC(1, 0x78, NULL), /* TxPktSz1024To1518 */ > MIB_DESC(1, 0x7c, NULL), /* TxPktSz1519ToMax */ > > - MIB_DESC(2, 0x80, NULL), /* TxGoodBytes */ > - /* 0x84 */ > - MIB_DESC(2, 0x88, NULL), /* TxCollision */ > - /* 0x8c */ > + /* 0x80 unused */ > + MIB_DESC(2, 0x84, NULL), /* TxGoodBytes */ > + /* 0x88 */ > + MIB_DESC(1, 0x8c, NULL), /* TxCollision */ > > MIB_DESC(1, 0x90, NULL), /* TxExcessiveCollistion */ > MIB_DESC(1, 0x94, NULL), /* TxMultipleCollision */ > @@ -705,7 +705,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, int port) > res = yt921x_reg_read(priv, reg + 4, &val1); > if (res) > break; > - val = ((u64)val0 << 32) | val1; > + val = ((u64)val1 << 32) | val0; > } > > WRITE_ONCE(*valp, val);