From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: __check_region in ide code?
Date: 06 Jun 2003 16:23:26 +0100 [thread overview]
Message-ID: <1054913005.17190.6.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.SOL.4.30.0306061053040.15859-100000@mion.elka.pw.edu.pl>
On Gwe, 2003-06-06 at 09:56, Bartlomiej Zolnierkiewicz wrote:
> > There's nothing inherently *wrong* with check_region, it's
> > just deprecated to trap the old (now racy) idiom of "if
> > (check_region(xx)) reserve_region(xx)". There's no reason not to
> > introduce a probe_region if IDE really wants it.
>
> And ide-probe.c does exactly this racy stuff.
>
> I did patch to convert it to request_region() some time ago,
> I just need to double check it and submit.
request_region at that point doesn't actually help you. For PIO devices
its too late if you are handling PCMCIA, for PCI devices its too late
because you want to own the PCI device properly, for MMIO its completely
broken (all the mem region stuff in 2.5)
The only way I can see to fix it properly is to provide ide helpers
for resource allocation that are used by the drivers when needed.
next prev parent reply other threads:[~2003-06-06 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-06 7:34 Rusty Russell
2003-06-06 8:56 ` Bartlomiej Zolnierkiewicz
2003-06-06 15:23 ` Alan Cox [this message]
2003-06-06 16:09 ` Bartlomiej Zolnierkiewicz
2003-06-06 11:31 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1054913005.17190.6.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®