From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0765B2FFDF0 for ; Sun, 26 Oct 2025 23:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761520603; cv=none; b=BEe9EPVdcZg7pAG2206GngGMxI6nMRNlh8/dSLfWM7dKWZnKPC889CYSOeFmMfsE14orktn8IrBKZRAsSpZXv1SiwcMS+YNRL3wYS9osAiOX7AV+ExNCIiqoxnDekCnNcrFO0CeFGTdQXnrd2HfoFiDnmZvLAksHiaRmCCDFV4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761520603; c=relaxed/simple; bh=0/huNYjZWSix9nRszyI3WMM5CbL2Lg55WENfuAt+bTI=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=OEsOytUQ3T/cU7aA1C81rIcmMEU0gCMrKw6Ac6xqyIwPdLk4/vEngHFcUENxH30Tq+cA+kBLfqkXDzLWBLmNzvmRmlXCwVv62ekPgjWmzi5WLn1QrqLLSfnNYP/O0nqE5mIEh427opPmojDMzbTyYOzVvQa3YV2M5z4W8Pu5sRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VcE11DJ+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VcE11DJ+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761520600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yBWykJ+JLfTQQ7sPIXkhPYL39cPjNvStkhNiSczPsqE=; b=VcE11DJ+gXe/PSvjZJwGNxkP6UAoPMh4h0qQICYNCDOmE5dITNYl3p89XTmCaDvmN1kzzw 4Fil+zQCE1x17OTe5D1fj+L+LdxKeAFLHWG03Fwz8NuWcoTgiBPBx31zuGYg5z7r0FZYyW rF2YB8ncs2NB2bgnPYYeB1mDVcnhpwM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-1OU8J2laMLSN1n_9SqwquA-1; Sun, 26 Oct 2025 19:16:39 -0400 X-MC-Unique: 1OU8J2laMLSN1n_9SqwquA-1 X-Mimecast-MFC-AGG-ID: 1OU8J2laMLSN1n_9SqwquA_1761520599 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-87fb496e4d1so136529996d6.3 for ; Sun, 26 Oct 2025 16:16:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761520599; x=1762125399; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yBWykJ+JLfTQQ7sPIXkhPYL39cPjNvStkhNiSczPsqE=; b=c/57Z3+8FYSFYKbFNB/klCDrUWD5cgJUby8ChYHQLtX1GZRsMTBpS9fS3QoxWAMrQB 5OL6E6UlzrzGTPffxZj/F9x9083XfbhnIpimkEhjoejtUk9RglNJWsbTSCg7Zmvb1h2t nsakuwLW+0ZhM1pymATEPv9FCZT+7iqz3A1U1lEtUmv2DuWwSgltj01quBWVO9XHiG2g RNe3DXWPyM+CE6PAJZg0460lklNoCotAoc4toX/Vl4wUOLl615pmMWiYW1ImX0zZPmSw r7USjHtiO7VPleE4Epg9kfBCAwcup/KKZQcdMExTvNFxTRAdmXabyNkwk5CaNUOoHVWO CYLg== X-Forwarded-Encrypted: i=1; AJvYcCWaHnYG8GA3gM1SFrJJAOjvi2kPm14TEq0OW6s0nAVnMeBMy4yPOsPAdJqOsHcV2W6Cu9e0L6PlGtSApYo=@vger.kernel.org X-Gm-Message-State: AOJu0YwIphT9n88x5NvrZwj1nU7XkPsoxFzMOr69yrsQpMm7+/yB7Igt gU3AugKuVGzQseN9fIv+rsYP3tqjg4Yb6Doof6mQ+HetvmAXTTcFIFgf0q7sBXebJURHcYMEdtc /JjPJgyunH1XgLTk6OPuUqMjnBXN3IeafeznU9qLUp5zX7+48VCeBfmU7YOdF7+Wo3w== X-Gm-Gg: ASbGncuuYB55NojFy1BPK8WuJweieply+IWazy7dOmwr9R/h0tn6elIstfZ+37em7VD Yi8UfT89vCtaV8yD/bt6JmVRLQu8z5qU3Vm1qDB5AKvdu/Q3WQ5UgxGmjQFPCdMiX0BgR1n52l7 luoIYEFUMR08Yvtzj4aFJJUXk8/51y8qx0lSzqE6hmmyd/k2FIbwWl6/wC6aOZSk1wFvRGlbR6r 6Df6umy6f5LDJoVv1h3iqtnccPQd+ASwZt4JNeBcHwMzfVQmwijPWP4T3dmnj+gghL9KNmNU05F b1/banqqVw6ooBKsOpYgZNpBQsL/dxK81v2iR/W40W+6FGQ2UUGs5MZw6UEzMKumlH6I9Np5CMX QBlVlXiaFtx3Y3j4JcTZeEEp43VZbxBbHDqOHCd+IGGvDNw== X-Received: by 2002:a05:6214:3010:b0:78f:4d53:7cd5 with SMTP id 6a1803df08f44-87c2055e413mr212351186d6.5.1761520598856; Sun, 26 Oct 2025 16:16:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUMbpyufTMcqOy5SlC0+mvXSrFqq3iNexFgoUnqdxkDBJdViCkPZAKJ8NUgAYACSCic30anA== X-Received: by 2002:a05:6214:3010:b0:78f:4d53:7cd5 with SMTP id 6a1803df08f44-87c2055e413mr212350986d6.5.1761520598526; Sun, 26 Oct 2025 16:16:38 -0700 (PDT) Received: from ?IPV6:2601:188:c180:4250:ecbe:130d:668d:951d? ([2601:188:c180:4250:ecbe:130d:668d:951d]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc49420absm39878736d6.33.2025.10.26.16.16.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Oct 2025 16:16:37 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <10579b1f-1005-4842-934f-0b9c6b65971d@redhat.com> Date: Sun, 26 Oct 2025 19:16:36 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] PCI/aer_inject: Adjust locking for PREEMPT_RT To: Guangbo Cui , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Thomas Gleixner , Bjorn Helgaas Cc: Jonathan Cameron , linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20251026044335.19049-2-jckeep.cuiguangbo@gmail.com> Content-Language: en-US In-Reply-To: <20251026044335.19049-2-jckeep.cuiguangbo@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/26/25 12:43 AM, Guangbo Cui wrote: > This patch series addresses locking issues in the AER injection > path under PREEMPT_RT. > > Signed-off-by: Guangbo Cui > --- > Changes in v3: > - Remove unnecessary lock in aer_inject_exit. > - Link to v2: https://lore.kernel.org/all/20251009150651.93618-1-jckeep.cuiguangbo@gmail.com/ > > --- > Guangbo Cui (2): > PCI/aer_inject: Convert inject_lock to raw_spinlock_t > PCI/aer_inject: Remove unnecessary lock in aer_inject_exit You should reverse the patch ordering. Patch 2 should come first before the patch 1. Otherwise, applying just patch 1 without patch 2 will fail compilation. Cheers, Longman > > drivers/pci/pcie/aer_inject.c | 33 +++++++++++++++------------------ > 1 file changed, 15 insertions(+), 18 deletions(-) >