From: <Alex_Gagniuc@Dellteam.com>
To: <helgaas@kernel.org>, <lukas@wunner.de>
Cc: <mr.nuke.me@gmail.com>, <Austin.Bolen@dell.com>,
<keith.busch@intel.com>, <Shyam.Iyer@dell.com>,
<mika.westerberg@linux.intel.com>, <okaya@codeaurora.org>,
<rafael.j.wysocki@intel.com>, <poza@codeaurora.org>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: pciehp: Report degraded links via link bandwidth notification
Date: Thu, 29 Nov 2018 23:24:58 +0000 [thread overview]
Message-ID: <10579c9bf79a42dd878c1e201bc9d254@ausx13mps321.AMER.DELL.COM> (raw)
In-Reply-To: <20181129230454.GF178809@google.com>
On 11/29/2018 5:05 PM, Bjorn Helgaas wrote:
> On Thu, Nov 29, 2018 at 08:13:12PM +0100, Lukas Wunner wrote:
>> I guess the interrupt is shared with hotplug and PME? In that case write
>> a separate pcie_port_service_driver and request the interrupt with
>> IRQF_SHARED. Define a new service type in drivers/pci/pcie/portdrv.h.
>> Amend get_port_device_capability() to check for PCI_EXP_LNKCAP_LBNC.
>
> I really don't like the port driver design. I'd rather integrate
> those services more tightly into the PCI core. But realistically
> that's wishful thinking and may never happen, so this might be the
> most expedient approach.
So, how would it get integrated? I don't like the port service driver
either. It's too dicky on how it creates some new devices that other
drives bind to. If we could have a 1:1 mapping between service drivers
and PCI capabilities, then it might make better sense.
So, do I go the new service driver route?
Alex
next prev parent reply other threads:[~2018-11-29 23:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 0:08 Alexandru Gagniuc
2018-11-29 16:06 ` Mika Westerberg
2018-11-29 19:00 ` Alex_Gagniuc
2018-11-29 19:30 ` Mika Westerberg
2018-11-29 17:35 ` Bjorn Helgaas
2018-11-29 18:57 ` Alex_Gagniuc
2018-11-29 19:13 ` Lukas Wunner
2018-11-29 23:04 ` Bjorn Helgaas
2018-11-29 23:24 ` Alex_Gagniuc [this message]
2018-12-07 18:20 ` [PATCH v2] " Alexandru Gagniuc
2018-12-27 19:33 ` Alex G.
2019-02-25 2:28 ` Lukas Wunner
2019-02-27 20:21 ` Alex_Gagniuc
2019-02-28 6:43 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10579c9bf79a42dd878c1e201bc9d254@ausx13mps321.AMER.DELL.COM \
--to=alex_gagniuc@dellteam.com \
--cc=Austin.Bolen@dell.com \
--cc=Shyam.Iyer@dell.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@codeaurora.org \
--cc=poza@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®