From: David Woodhouse <dwmw2@infradead.org>
To: Richard Curnow <Richard.Curnow@superh.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>,
Ben Gaster <Benedict.Gaster@superh.com>,
Sean McGoogan <sean.mcgoogan@superh.com>,
Boyd Moffat <boyd.moffat@superh.com>
Subject: Re: NFS structure allocation alignment patch
Date: Fri, 18 Jul 2003 17:10:39 +0100 [thread overview]
Message-ID: <1058544639.29924.15.camel@passion.cambridge.redhat.com> (raw)
In-Reply-To: <20030716150326.GA320@malvern.uk.w2k.superh.com>
On Wed, 2003-07-16 at 16:03, Richard Curnow wrote:
> Apart from this issue, we haven't seen any code- or compiler-related
> problems due to misaligned loads and stores occurring.
That doesn't mean they don't exist. Various parts of the network code
_require_ alignment fixups -- the common case is that it'll be aligned,
and we take the hit only in the _rare_ case of misalignment rather than
using get_unaligned() in the fast path.
Also the flash code does the same in places too. It _did_ use
get_unaligned() for a while but it was removed since it's never valid
for an architecture to _not_ fix up unaligned in-kernel accesses.
> I bet someone will wonder how the misalignment hadn't shown up before.
Because all other architectures implement alignment fixups.
--
dwmw2
prev parent reply other threads:[~2003-07-18 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-30 13:52 Richard Curnow
2003-07-10 11:05 ` David Woodhouse
2003-07-16 15:03 ` Richard Curnow
2003-07-18 16:10 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1058544639.29924.15.camel@passion.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=Benedict.Gaster@superh.com \
--cc=Richard.Curnow@superh.com \
--cc=boyd.moffat@superh.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=sean.mcgoogan@superh.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®