mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Jan Kasprzak <kas@informatics.muni.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Patch] Non-ASCII chars in visor.c messages
Date: 22 Jul 2003 15:16:28 +0100	[thread overview]
Message-ID: <1058883388.2751.13.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030722125039.GA2310@kroah.com>

On Maw, 2003-07-22 at 13:50, Greg KH wrote:
> > 	The visor.c module contains three messages
> > with non-ASCII character ("e" with acute above, encoded in
> > ISO 8859-1, in the name of "Sony Clie'" handheld). I propose the attached
> > patch, which works in all environments (altough UTF-8 variant would be
> > IMHO fine as well).
> > 
> > 	What do you think about it?
> 
> I don't think it's really needed.  Why change this, syslog can't handle
> this?  It works for me...

Current syslog has problems handling it. These problems are a lot worse
than they appear too. Since the file system encoding is UTF-8 for file
naming the syslog daemon is sometimes logging kernel file path objects
which are unicode utf-8 format. 

The highbit corrupted characters in the C files (as well as being iffy
C) causes problems we just don't need. 

It doens't really matter if we pick UTF-8 (which does mean things like
names can be handled ok) or plain 7bit ascii C locale but we need to
pick something.


  parent reply	other threads:[~2003-07-22 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-22 12:38 Jan Kasprzak
2003-07-22 12:50 ` Greg KH
2003-07-22 13:09   ` Jan Kasprzak
2003-07-22 13:18     ` Greg KH
2003-07-22 14:03       ` Jan Kasprzak
2003-07-22 14:16   ` Alan Cox [this message]
2003-07-23 11:16   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1058883388.2751.13.camel@dhcp22.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=kas@informatics.muni.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®