From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753405AbbKWH3q (ORCPT ); Mon, 23 Nov 2015 02:29:46 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:58161 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbbKWH3o (ORCPT ); Mon, 23 Nov 2015 02:29:44 -0500 X-AuditID: cbfee68f-f79666d0000076bb-ce-5652c067aea3 Date: Mon, 23 Nov 2015 07:29:43 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH 4/6] PM / devfreq: Set the freq_table of devfreq device To: =?utf-8?Q?=EC=B5=9C=EC=B0=AC=EC=9A=B0?= , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20151123072648535@myungjoo.ham Msgkey: 20151123072648535@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20151123072648535@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <106136506.126661448263783195.JavaMail.weblogic@epmlwas06a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkQDf9QFCYwZIN4haXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugSvj6qNljAWfhCo+7NjB0sC4QaiLkZNDSEBdYtGSk2wgtoSAicS7 Nf/ZIWwxiQv31gPFuYBqljJKbHk9hQmmqKthMlRiDqPEyfZtjCAJFgFVib/3O4G6OTjYBPQk Zn5OBgkLC3hLLJjXzAxSLyLQxyhx+PdssA3MAlUSq479Yoe4Qklizb5XLCA2r4CgxMmZT1gg lqlKXP21jB0iriax/OoiqEvFJS7MvQR1Ka/EjPanUPVyEtO+rmGGsKUlzs/awAjzzeLvj6Hi /BLHbu+AekZAYuqZg4wgN0sIaEm8myAOEeaTWLPwLQtM+a5Ty5lhVt3fMheqVUJia8sTVohX FCWmdD8Ee51ZQFNi/S59dJ/wCrhLNO+7xQ4KBgmBqRwS/ce62CYwKs1CUjcLyahZCKOQlSxg ZFnFKJpakFxQnJReZKxXnJhbXJqXrpecn7uJEZgWTv971r+D8e4B60OMAhyMSjy8mvpBYUKs iWXFlbmHGE2BkTSRWUo0OR+YfPJK4g2NzYwsTE1MjY3MLc2UxHkXSv0MFhJITyxJzU5NLUgt ii8qzUktPsTIxMEp1cBYNqeqbsXts0UL3zvmJy8+62hfIaur7falYenZx05t6QebfWOj6g1n W7Zcacu8yRnx4voCVcX9HzQl54sfDOVPn6YeH/C6aOPnpGnyOnXbH/y877o7bc38ZSVrmSe+ 3L1vwSv7dJtddyfWtRQ6Gjt3xfk//c/3WPmHRoxngZy7qrjT4r2aVhxKLMUZiYZazEXFiQCA TyNXBgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tft30A0FhBsuXCVlc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q+NYK0MDAyNToJqEtIyr j5YxFnwSqviwYwdLA+MGoS5GTg4hAXWJRUtOsoHYEgImEl0Nk6FsMYkL99YD2VxANXMYJU62 b2MESbAIqEr8vd/J3sXIwcEmoCcx83MySFhYwFtiwbxmZpB6EYE+RonDv2ezgySYBaokVh37 xQ6xTElizb5XLCA2r4CgxMmZT1gglqlKXP21jB0iriax/OoiqCPEJS7MvcQOYfNKzGh/ClUv JzHt6xpmCFta4vysDYwwRy/+/hgqzi9x7PYOJghbQGLqmYOMIDdLCGhJvJsgDhHmk1iz8C0L TPmuU8uZYVbd3zIXqlVCYmvLE1aIVxQlpnQ/BHudWUBTYv0ufXSf8Aq4SzTvu8U+gVF2FpLU LCTdsxC6kZUsYGRZxSiaWpBcUJyUXmGiV5yYW1yal66XnJ+7iRGcgp4t2cHYcMH6EKMAB6MS D6+GflCYEGtiWXFl7iFGCQ5mJRHeI1uBQrwpiZVVqUX58UWlOanFhxhNgVE2kVlKNDkfmB7z SuINjY1NzExMLU0sDEzNlcR5b+/zCxMSSE8sSc1OTS1ILYLpY+LglGpgbLVjulmplNQvwZec yHFCqC/4YNzzSZ/uC0usMni6yG/KTR/F2GN7lV5Gi1++FVb6UMH+0tIp/o0HvXMqrv1X2MWo dEesPEzaPtt8kr7P8Q0N0YHHGNU+lKRYKjbEBQYur/ya73T/38f2C8VZMYmefJ01abnWye4P Q4yb1aquXC68eVvi1B4lluKMREMt5qLiRAC6S2vEVwMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAN7Tow2010581 > > This patch initialize the freq_table array of each devfreq device by using > the devfreq_set_freq_table(). If freq_table is NULL, the devfreq framework > is not able to support the frequency transtion information through sysfs. > > The OPP core uses the integer type for the number of opps in the opp list > and uses the 'unsigned long' type for each frequency. So, this patch modifies > the type of some variable as following: > - the type of freq_table : unsigned int -> unsigned long > - the type of max_state : unsigned int -> int > > Signed-off-by: Chanwoo Choi [] > +/** > * devfreq_update_status() - Update statistics of devfreq behavior > * @devfreq: the devfreq instance > * @freq: the update target frequency > @@ -477,7 +516,12 @@ struct devfreq *devfreq_add_device(struct device *dev, > devfreq->previous_freq = profile->initial_freq; > devfreq->data = data; > devfreq->nb.notifier_call = devfreq_notifier_call; > + mutex_unlock(&devfreq->lock); > > + if (devfreq->profile->max_state <= 0 && !devfreq->profile->freq_table) > + devfreq_set_freq_table(devfreq); > + > + mutex_lock(&devfreq->lock); Anyway, what about modifying the block above as: + if (!devfreq->profile->max_state && !devfreq->profile->freq_table) { + mutex_unlock(&devfreq->lock); devfreq_set_freq_table(devfreq); + mutex_lock(&devfreq->lock); + } > devfreq->trans_table = devm_kzalloc(dev, sizeof(unsigned int) * > devfreq->profile->max_state * > devfreq->profile->max_state, [] If that's not a problem, I'll squash https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rafael&id=55df2b43cdb5ac82d26b64d739f3d758c9b7486c with the given patch. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I