mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: core: Add of_node_put() before return
Date: Tue, 13 Aug 2019 09:57:47 +0530	[thread overview]
Message-ID: <106177ee-d6e0-5825-83f0-ca199b05ac20@gmail.com> (raw)
In-Reply-To: <20190808122740.GB3795@sirena.co.uk>

On 08/08/19 5:57 PM, Mark Brown wrote:
> On Thu, Aug 08, 2019 at 12:35:53PM +0530, Nishka Dasgupta wrote:
>> In function of_get_child_regulator(), the loop for_each_child_of_node()
>> contains two mid-loop return statements. Ordinarily the loop gets the
>> node child at the beginning of every iteration and automatically puts
> 
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code.  Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
> 
I am very sorry about this; I wasn't sure whether this particular commit 
had been applied. Should I split the commit and resend only the change 
to the old commit, or should I leave it as it is?

Thanking you,
Nishka

  reply	other threads:[~2019-08-13  4:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08  7:05 Nishka Dasgupta
2019-08-08 12:27 ` Mark Brown
2019-08-13  4:27   ` Nishka Dasgupta [this message]
2019-08-13 11:21     ` Mark Brown
2019-08-15  5:37       ` [PATCH v2] regulator: core: Add label to collate of_node_put() statements Nishka Dasgupta
2019-08-15 17:14         ` Applied "regulator: core: Add label to collate of_node_put() statements" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=106177ee-d6e0-5825-83f0-ca199b05ac20@gmail.com \
    --to=nishkadg.linux@gmail.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®