From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAA7C07E95 for ; Sat, 10 Jul 2021 17:04:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 732E361185 for ; Sat, 10 Jul 2021 17:04:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230325AbhGJRHh (ORCPT ); Sat, 10 Jul 2021 13:07:37 -0400 Received: from smtprelay0137.hostedemail.com ([216.40.44.137]:36890 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229490AbhGJRHh (ORCPT ); Sat, 10 Jul 2021 13:07:37 -0400 Received: from omf06.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 3AF3E837F253; Sat, 10 Jul 2021 17:04:51 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id 3852D2448BF; Sat, 10 Jul 2021 17:04:50 +0000 (UTC) Message-ID: <10621e048f62018432c42a3fccc1a5fd9a6d71d7.camel@perches.com> Subject: Re: [PATCH] dax: replace sprintf() by scnprintf() From: Joe Perches To: Salah Triki , dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org Date: Sat, 10 Jul 2021 10:04:48 -0700 In-Reply-To: <20210710164615.GA690067@pc> References: <20210710164615.GA690067@pc> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 3852D2448BF X-Stat-Signature: r9mp75uipcc9qgr86rf8isradagw5869 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19qjiJ4bEM3l7ZhvAJzq+B4x7oGaQz405Y= X-HE-Tag: 1625936690-706479 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-07-10 at 17:46 +0100, Salah Triki wrote: > Replace sprintf() by scnprintf() in order to avoid buffer overflows. OK but also not strictly necessary. DAX_NAME_LEN is 30. Are you finding and changing these manually or with a script? > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c [] > @@ -76,7 +76,7 @@ static ssize_t do_id_store(struct device_driver *drv, const char *buf, >   fields = sscanf(buf, "dax%d.%d", ®ion_id, &id); >   if (fields != 2) >   return -EINVAL; > - sprintf(devname, "dax%d.%d", region_id, id); > + scnprintf(devname, DAX_NAME_LEN, "dax%d.%d", region_id, id); >   if (!sysfs_streq(buf, devname)) >   return -EINVAL; >   >