mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Jens Axboe <axboe@suse.de>,
	linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [PATCH] IDE: Enable LED support for PowerMac
Date: Wed, 03 Sep 2003 18:14:58 +0200	[thread overview]
Message-ID: <1062605698.1780.33.camel@gaston> (raw)

Hi Bart !

Please submit that to Linus. It adds the Kconfig option for the
PowerMac IDE driver "LED" feature (using the laptop's front LED
as a disk activity indicator). It also adds a small bit to ide-probe.c
that was missing from Jens patch when he added the activity function
infrastructure. He did add the hwif field, but not the code to actually
enable it.

Ben.


diff -urN for-linus-ppc/drivers/ide/Kconfig
linuxppc-2.5-benh/drivers/ide/Kconfig
--- for-linus-ppc/drivers/ide/Kconfig	2003-09-03 18:07:14.000000000
+0200
+++ linuxppc-2.5-benh/drivers/ide/Kconfig	2003-08-25 22:04:14.000000000
+0200
@@ -835,6 +835,13 @@
 	  to transfer data to and from memory.  Saying Y is safe and improves
 	  performance.
 
+config BLK_DEV_IDE_PMAC_BLINK
+	bool "Blink laptop LED on drive activity"
+	depends on BLK_DEV_IDE_PMAC && ADB_PMU
+	help
+	  This option enables the use of the sleep LED as a hard drive
+	  activity LED.
+
 config BLK_DEV_IDEDMA_PMAC_AUTO
 	bool "Use DMA by default"
 	depends on BLK_DEV_IDEDMA_PMAC
@@ -993,6 +1000,15 @@
 
 endchoice
 
+config BLK_DEV_IDE_STB04xxx
+	bool "STB04xxx (Redwood-5) IDE support"
+	depends on BLK_DEV_IDE && REDWOOD_5
+	help
+	  This option provides support for IDE on IBM STB04xxx Redwood-5
+	  systems.
+
+	  If unsure, say N.
+
 # no isa -> no vlb
 config IDE_CHIPSETS
 	bool "Other IDE chipset support"
diff -urN for-linus-ppc/drivers/ide/ide-probe.c
linuxppc-2.5-benh/drivers/ide/ide-probe.c
--- for-linus-ppc/drivers/ide/ide-probe.c	2003-09-03 18:07:14.000000000
+0200
+++ linuxppc-2.5-benh/drivers/ide/ide-probe.c	2003-09-03
18:05:12.000000000 +0200
@@ -958,6 +958,10 @@
 	/* needs drive->queue to be set */
 	ide_toggle_bounce(drive, 1);
 
+	/* enable led activity for disk drives only */
+	if (drive->media == ide_disk && hwif->led_act)
+		blk_queue_activity_fn(q, hwif->led_act, drive);
+
 	return 0;
 }
 



             reply	other threads:[~2003-09-03 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-03 16:14 Benjamin Herrenschmidt [this message]
2003-09-03 16:17 ` Benjamin Herrenschmidt
2003-09-03 16:43 ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1062605698.1780.33.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®