From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Patrick Mochel <mochel@osdl.org>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Power: call save_state on PCI devices along with suspend
Date: Tue, 09 Sep 2003 23:09:32 +0200 [thread overview]
Message-ID: <1063141771.639.53.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.44.0309091354471.695-100000@cherise>
On Tue, 2003-09-09 at 23:04, Patrick Mochel wrote:
> > Don't we want that ? It will help if any driver currently relies on
> > the save_state callback to be called...
>
> Bah, this patch slipped my mind. How many drivers actually use
> ->save_state()? From a quick look, it looks like:
>
> 1. drivers/ide/pci/sc1200.c
> 2. drivers/net/irda/vlsi_ir.c
> 3. drivers/scsi/nsp32.c
> 4. drivers/serial/8250_pci.c
>
> Of those, only (1) actually does anything interesting. (2) and (3) only
> print a message, and (4) appears to be trivial to fold into ->suspend().
>
> What do you think about just fixing those up?
Well... that wouldn't help with off-tree drivers...
What I mean here is that our PCI driver API defines save_state, we shall
either "support" it some way, or get rid of it completely... but then we
lose the ability to move a PCI driver back & forth with 2.4 ... (do we
care ?)
If you prefer just fixing those 4 ones, then let's get rid of the
save_state field in pci_driver completely...
Ben.
next prev parent reply other threads:[~2003-09-09 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 18:41 Benjamin Herrenschmidt
2003-09-09 21:04 ` Patrick Mochel
2003-09-09 21:09 ` Benjamin Herrenschmidt [this message]
2003-09-09 21:20 ` Russell King
2003-09-09 21:46 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1063141771.639.53.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®