From: Ram Pai <linuxram@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Badari Pulavarty <pbadari@us.ibm.com>,
slpratt@us.ibm.com, suparna@in.ibm.com,
linux-kernel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [PATCH][2.6-mm] Readahead issues and AIO read speedup
Date: 22 Sep 2003 17:41:07 -0700 [thread overview]
Message-ID: <1064277666.9807.46.camel@dyn319480.beaverton.ibm.com> (raw)
In-Reply-To: <20030807135819.3368ee16.akpm@osdl.org>
On Thu, 2003-08-07 at 13:58, Andrew Morton wrote:
> Badari Pulavarty <pbadari@us.ibm.com> wrote:
> >
> > On Thursday 07 August 2003 10:39 am, Andrew Morton wrote:
> > > Badari Pulavarty <pbadari@us.ibm.com> wrote:
> > > > We should do readahead of actual pages required by the current
> > > > read would be correct solution. (like Suparna suggested).
> > >
> > > I repeat: what will be the effect of this if all those pages are already in
> > > pagecache?
> >
> > Hmm !! Do you think just peeking at pagecache and bailing out if
> > nothing needed to be done, is too expensive ? Anyway, slow read
> > code has to do this later. Doing it in readahead one more time causes
> > significant perf. hit ?
>
> It has been observed, yes.
we found substantial improvements (around 20% )in Database decision
support work load on Filesystems.
To address your concern regarding possible SDET regression generated by
this patch, we (Steve Pratt) ran a bunch of regression tests on
2.6.0test5-mm2(with and without the patch). I have pasted the results of
SDET and Kernel Bench. We did not find any noticable performance
regression.
Here are some results from Steve on test5-mm2
**************************************************************************
sdet comparison
of
2.6.0-test5-mm2 vs 2.6.0-test5mm2-without-READAHEAD-patch
Results:Throughput
tolerance = 0.00 + 3.00% of 2.6.0-test5-mm2
2.6.0-test5-mm2 2.6.0-test5mm2-without-READAHEAD
Threads Ops/sec Ops/sec %diff diff tolerance
---------- ------------ ------------ -------- ------------ ------------
1 3089 3103 0.45 14.00 92.67
4 11181 11294 1.01 113.00 335.43
16 18436 18530 0.51 94.00 553.08
64 18867 19002 0.72 135.00 566.01
****************************************************************************
**************************************************************************
kernbench comparison
of
2.6.0-test5-mm2 vs 2.6.0-test5mm2-without-READAHEAD
Results:Elapsed Time
tolerance = 0.00 + 3.00% of 2.6.0-test5-mm2
2.6.0-test5-mm2 2.6.0-test5mm2-without-READAHEAD
Seconds Seconds %diff diff tolerance
---------- ------------ ------------ -------- ------------ ------------
2 96.015 95.035 -1.02 -0.98 2.88
**************************************************************************
Would you like us to run some other tests?
Thanks,
RP
>
> > And also, do you think this is the most common case ?
>
> It is a very common case. It's one we need to care for. Especially when
> lots of CPUs are hitting the same file.
>
> There are things we can do to tweak it up, such as adding a max_index to
> find_get_pages(), then do multipage lookups, etc. But not doing it at all
> is always the fastest way.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2003-09-23 0:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-07 10:01 Suparna Bhattacharya
2003-08-07 16:01 ` Badari Pulavarty
2003-08-07 16:28 ` Andrew Morton
2003-08-07 17:21 ` Badari Pulavarty
2003-08-07 17:39 ` Andrew Morton
2003-08-07 20:41 ` Badari Pulavarty
2003-08-07 20:58 ` Andrew Morton
2003-08-08 13:56 ` Suparna Bhattacharya
2003-08-13 21:06 ` Ram Pai
2003-09-23 0:41 ` Ram Pai [this message]
2003-08-07 19:36 ` Joel Becker
2003-08-08 5:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064277666.9807.46.camel@dyn319480.beaverton.ibm.com \
--to=linuxram@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=slpratt@us.ibm.com \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®