From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261637AbTIXWdc (ORCPT ); Wed, 24 Sep 2003 18:33:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261640AbTIXWdb (ORCPT ); Wed, 24 Sep 2003 18:33:31 -0400 Received: from DSL022.labridge.com ([206.117.136.22]:58119 "EHLO Perches.com") by vger.kernel.org with ESMTP id S261637AbTIXWda (ORCPT ); Wed, 24 Sep 2003 18:33:30 -0400 Subject: [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h From: Joe Perches To: Linus Torvalds Cc: David S Miller , Kernel Mailing List , netdev@oss.sgi.com In-Reply-To: <1064423867.15283.11.camel@localhost.localdomain> References: <1064423867.15283.11.camel@localhost.localdomain> Content-Type: text/plain Message-Id: <1064442780.15437.25.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Wed, 24 Sep 2003 15:33:00 -0700 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2003-09-24 at 10:17, Joe Perches wrote: > On Wed, 2003-09-24 at 10:13, Linus Torvalds wrote: > > Looks sane, but wouldn't it be cleaner to put this ugly special case logic > > with casts etc in an inline function and make the code a bit more readable > > at the same time? > > I've got those. > > I've done the ((void*)1) conversions to PKT_SHARED_SKBs > and found this missing. I'll submit those separately. diff -urN linux-2.6.0-test5/include/linux/netdevice.h shared_skb/include/linux/netdevice.h -- linux-2.6.0-test5/include/linux/netdevice.h 2003-09-22 08:04:03.000000000 -0700 +++ shared_skb/include/linux/netdevice.h 2003-09-22 13:10:07.000000000 -0700 @@ -477,6 +477,7 @@ */ #define SET_NETDEV_DEV(net, pdev) ((net)->class_dev.dev = (pdev)) +#define PKT_CAN_SHARE_SKB ((void*)1) struct packet_type {