Re: IA32 - 6 New warnings (gcc 3.2.2)

[John Cherry <cherry@osdl.org>]

On Fri, 2003-09-26 at 08:56, Adrian Bunk wrote:
> On Thu, Sep 25, 2003 at 10:48:35PM -0700, John Cherry wrote:
> >...
> > drivers/char/drm/sis_mm.c:92: warning: unused variable `req'
> >...
> 
> Looking at the code, this seems to be a bogus warning in the gcc version
> you are using.
> 
> cu
> Adrian

Yes, this warning looks bogus.  Hard to understand why this was flagged
as a warning by gcc 3.2.2...

int sis_fb_alloc( DRM_IOCTL_ARGS )
{
        drm_sis_mem_t fb;
-->     struct sis_memreq req;
        int retval = 0;
                                                                                
        DRM_COPY_FROM_USER_IOCTL(fb, (drm_sis_mem_t *)data, sizeof(fb));
                                                                                
        req.size = fb.size;
-->     sis_malloc(&req);
        if (req.offset) {
                /* TODO */
                fb.offset = req.offset;
                fb.free = req.offset;
                if (!add_alloc_set(fb.context, VIDEO_TYPE, fb.free)) {
                        DRM_DEBUG("adding to allocation set fails\n");
                        sis_free(req.offset);
                        retval = DRM_ERR(EINVAL);
                }
        } else {
                fb.offset = 0;
                fb.size = 0;
                fb.free = 0;
        }
<snip>

John